-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model Update] Get production forecast 2.0.0 #553
[Model Update] Get production forecast 2.0.0 #553
Conversation
# | ||
# SPDX-License-Identifier: CC-BY-4.0 | ||
########################################################################################## | ||
@prefix samm: <urn:samm:org.eclipse.esmf.samm:meta-model:2.0.0#>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change to samm:meta-model:2.1.0
@prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>. | ||
@prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#>. | ||
@prefix xsd: <http://www.w3.org/2001/XMLSchema#>. | ||
@prefix : <urn:samm:io.catenax.shopfloor_information.production_forecast_request:2.0.0#>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
namespace and the folder name should always be same. either please correct aspect namespace or folder name.
Also for v1.0.0, I noticed that the namespace was changed after publishing the aspect. this is not good. please correct that also if it is still in use.
…ch it is provided
Thank you for your feedback! I just pushed the latest version and similar to the shopfloor_information_types, I set the samm metamodel to 2.1.0, removed the spaces at the end and set version 1.0.0 to deprecated. Looking forward to your feedback! |
samm:characteristic ext-types2:TimeValueCharacteristic. | ||
|
||
:customerId a samm:Property; | ||
samm:preferredName "customerId"@en; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
preferredName should be human readable and follow normal orthography (e.g., no camel case but normal word separation)
samm:exampleValue "false"^^xsd:boolean. | ||
|
||
:orderId a samm:Property; | ||
samm:preferredName "orderId"@en; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check my comments
@FlorianDue |
|
That's fine. We would also like to get MS3 on Monday for these 3 models (#553 #554 and #551) Are there any steps that we have to do? For example create a new issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Nothing else is required. We are good for MS3 in next meeting. please make sure someone from your team is there in meeting on Monday to present the model. |
Sure, ill be there. See you Monday and have a nice weekend! |
Description
Message Header and shopfloor_information_types are updated to version 2.0.0updated
-->
Closes #533
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)