[Model Update]: market palce offer_v2.0.0

[yuchengluo1]

Description

As mentioned in issue: #482.

-->

Closes #482

MS2 Criteria

(to be filled out by PR reviewer)

• the model validates with the SAMM SDS SDK in the version specified in the Readme.md of this repository by the time of the MS2 check (e.g., 'java -jar samm-cli.jar aspect <path-to-aspect-model> validate ). The SAMM CLI is available here and in GitHub
• use Camel-Case (e.g., "MyModelElement" or "TimeDifferenceGmtId", when in doubt follow https://google.github.io/styleguide/javaguide.html#s5.3-camel-case)
• the identifiers for all model elements start with a capital letter except for properties
• the identifier for properties starts with a small letter
• all model elements at least contain the fields "preferred name" and "description" in English language. The description must be comprehensible. It is not required to write full sentences but style should be consistent over the whole model
• Property and the referenced Characteristic should not have the same name
• the versioning in the URN follows semantic versioning, where minor version bumps are backwards compatible and major version bumps are not backwards compatible.
• use abbreviations only when necessary and if these are sufficiently common
• avoid redundant prefixes in property names (consider adding properties to an enclosing Entity or even adapt the namespace of the model elements, e.g., instead of having two properties DismantlerId and DismantlerName use an Entity Dismantler with the properties name and id or use a URN like io.catenax.dismantler:0.0.1)
• fields preferredName and description are not the same
• preferredName should be human readable and follow normal orthography (e.g., no camel case but normal word separation)
• name of aspect is singular except if it only has one property which is a Collection, List or Set. In theses cases, the aspect name is plural.
• units are referenced from the SAMM unit catalog whenever possible
• use constraints to make known constraints from the use case explicit in the aspect model
• when relying on external standards, they are referenced through a "see" element
• all properties with an simple type have an example value
• metadata.json exists with status "release"
• generated json schema validates against example json payload
• file RELEASE_NOTES.md exists and contains entries for proposed model changes
• all contributors to this model are mentioned in copyright header of model file

MS3 Criteria

(to be filled out by semantic modeling team before merge to main-branch)

• All required reviewers have approved this PR (see reviewers section)
• The new aspect (version) will be implemented by at least one data provider
• The new aspect (version) will be consumed by at least one data consumer
• There exists valid test data
• In case of a new (incompatible) major version to an existing version, a migration strategy has been developed
• The model has at least version '1.0.0'
• If a previous model exists, model deprecation has been checked for previous model
• The release date in the Release Note is set to the date of the MS3 approval

[yuchengluo1]

@agg3fe This updated model version contains a shared-aspect (the PhysicalDimensions aspect model), which is still modelled with old bamm-model version, which caused conflict when it is merged into a samm-model. What should I do in this case?

[agg3fe]

@agg3fe This updated model version contains a shared-aspect (the PhysicalDimensions aspect model), which is still modelled with old bamm-model version, which caused conflict when it is merged into a samm-model. What should I do in this case?

The solution would be to first convert PhysicalDimensions aspect model to samm meta model.

[yuchengluo1]

@agg3fe This updated model version contains a shared-aspect (the PhysicalDimensions aspect model), which is still modelled with old bamm-model version, which caused conflict when it is merged into a samm-model. What should I do in this case?

The solution would be to first convert PhysicalDimensions aspect model to samm meta model.

Do I need to raise a new model version (v2.0.1) for it?
According to the record, the samm model was reverted back to bamm model last year:
Revert "update to samm"

[agg3fe]

@agg3fe This updated model version contains a shared-aspect (the PhysicalDimensions aspect model), which is still modelled with old bamm-model version, which caused conflict when it is merged into a samm-model. What should I do in this case?

The solution would be to first convert PhysicalDimensions aspect model to samm meta model.

Do I need to raise a new model version (v2.0.1) for it? According to the record, the samm model was reverted back to bamm model last year: Revert "update to samm"

I am not sure about the reason for converting back to bamm. But a new version 3.0.0 would be required as this is not compatible with old 2.0.0 bamm version.

[agg3fe]

please check if you are able to use https://github.com/eclipse-tractusx/sldt-semantic-models/blob/main/io.catenax.shared.quantity/1.0.0/Quantity.ttl model here.

[yuchengluo1]

If it is linked to Quantity aspect, the property "dimensions" has both mass and linear characteristic. However I cannot link a single property to 2 characteristics. Do you have a solution here? Or should I still use the physical dimension aspect?

[catroest]

Quantity: You can link it directly to each specific characterisitc (for reference i did the same in the digital product passport). For weight to the massCharacteristic, for the others each to the linear characteristic.
(Physical Dimensions: This model is very restrictive (as of now) and the unit can not be adjusted.)

[agg3fe]

Thanks @catroest for helping here.
@yuchengluo1 here's the example https://github.com/eclipse-tractusx/sldt-semantic-models/blob/main/io.catenax.generic.digital_product_passport/3.0.0/DigitalProductPassport.ttl#L665.

[github-actions]

Validation Report for io.catenax.market_place_offer/2.0.0/MarketplaceOffer.ttl

Input model is valid

[agg3fe]

@yuchengluo1 is this model ready for MS2 check?

[github-actions]

Validation Report for io.catenax.market_place_offer/2.0.0/MarketplaceOffer.ttl

Input model is valid

[agg3fe]

please check my comments

[github-actions]

Validation Report for io.catenax.market_place_offer/2.0.0/MarketplaceOffer.ttl

Input model is valid

[yuchengluo1]

Does the model fullfill the MS2 requirement? Could we try to get MS3 approval this afternoon?

[agg3fe]

Does the model fullfill the MS2 requirement? Could we try to get MS3 approval this afternoon?

Thanks for resolving the issues. Please resolve the two comments left, then we are good to go for MS3.

[github-actions]

Validation Report for io.catenax.market_place_offer/2.0.0/MarketplaceOffer.ttl

Input model is valid

[agg3fe]

LGTM

[agg3fe]

serial part 3.0.0

[github-actions]

Validation Report for io.catenax.market_place_offer/2.0.0/MarketplaceOffer.ttl

Validation failed:

[yuchengluo1]

is it ok now?