-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Fleet.DiagnosticData to 2.0.0 #518
Update Fleet.DiagnosticData to 2.0.0 #518
Conversation
Validation Report for io.catenax.fleet.diagnostic_data/2.0.0/DiagnosticData.ttlInput model is valid |
@agg3fe please do the review - the most complex model of QAX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check my comments
Validation Report for io.catenax.fleet.diagnostic_data/2.0.0/DiagnosticData.ttlInput model is valid |
Validation Report for io.catenax.fleet.diagnostic_data/2.0.0/DiagnosticData.ttlInput model is valid |
@agg3fe Please re-assess - I hope I covered every finding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Validation Report for io.catenax.fleet.diagnostic_data/2.0.0/DiagnosticData.ttlInput model is valid |
Validation Report for io.catenax.fleet.claim_data/2.0.0/ClaimData.ttlInput model is valid |
Validation Report for io.catenax.fleet.diagnostic_data/2.0.0/DiagnosticData.ttlInput model is valid |
Validation Report for io.catenax.fleet.diagnostic_data/2.0.0/DiagnosticData.ttlInput model is valid |
1 similar comment
Validation Report for io.catenax.fleet.diagnostic_data/2.0.0/DiagnosticData.ttlInput model is valid |
Validation Report for io.catenax.fleet.diagnostic_data/2.0.0/DiagnosticData.ttlInput model is valid |
Description
This PR reflects all changes for Fleet.DIagnosticData 2.0.0:
Added
Changed
Removed
Closes #418
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)