-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model Update]: Battery Pass #499
[Model Update]: Battery Pass #499
Conversation
valid with the merge of #498 as it includes this version in several imports |
@tom-rm-meyer-ISST please MS2 review. The model is valid, after the merge of the Digital Product Passport PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my comments. Also you can update your PR as digital product passport is merged.
Validation Report for io.catenax.battery.battery_pass/4.0.0/BatteryPass.ttlInput model is valid |
Validation Report for io.catenax.battery.battery_pass/4.0.0/BatteryPass.ttlInput model is valid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Validation Report for io.catenax.battery.battery_pass/4.0.0/BatteryPass.ttlInput model is valid |
All required reviewers have approved this PR (see reviewers section) --> OK MS3 approval given by the group @agg3fe please merge |
Validation Report for io.catenax.battery.battery_pass/4.0.0/BatteryPass.ttlInput model is valid |
6dab4e1
into
eclipse-tractusx:main
Description
Fundamental changes to be conform with the latest release of the regulation.
-->
Closes #194
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)