-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model Update]: ReuseCertificate_v2.0.0 #477
Conversation
Validation Report for io.catenax.reuse_certificate/2.0.0/ReuseCertificate.ttlInput model is valid |
@@ -3,6 +3,16 @@ All notable changes to this model will be documented in this file. | |||
|
|||
## [Unreleased] | |||
|
|||
## [2.0.0] - 2023-11-20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change the date to today's date if you want MS3 today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I just saw the message, should I still change o 11.27, or to 12.04 which is next Monday?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can change it to 12.04 now for our next weekly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my comments.
Validation Report for io.catenax.reuse_certificate/2.0.0/ReuseCertificate.ttlInput model is valid |
@yuchengluo1 please also add missing |
Validation Report for io.catenax.reuse_certificate/2.0.0/ReuseCertificate.ttlInput model is valid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Validation Report for io.catenax.reuse_certificate/2.0.0/ReuseCertificate.ttlInput model is valid |
Description
As mentioned in issue #324 and in pull request #420. A new version of this model is generated.
-->
Closes #324
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)