Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Model Update]: RefurbishingCertificate_v2.0.0 #464

Merged
merged 8 commits into from
Dec 11, 2023
Merged

[Model Update]: RefurbishingCertificate_v2.0.0 #464

merged 8 commits into from
Dec 11, 2023

Conversation

yuchengluo1
Copy link
Contributor

@yuchengluo1 yuchengluo1 commented Nov 19, 2023 •
edited by agg3fe
Loading

Description

As mentioned in issue #326 and in pull request #420. A new version of this model is generated.

-->

Closes #326

MS2 Criteria

(to be filled out by PR reviewer)

  • the model validates with the SAMM SDS SDK in the version specified in the Readme.md of this repository by the time of the MS2 check (e.g., 'java -jar samm-cli.jar aspect <path-to-aspect-model> validate ). The SAMM CLI is available here and in GitHub
  • use Camel-Case (e.g., "MyModelElement" or "TimeDifferenceGmtId", when in doubt follow https://google.github.io/styleguide/javaguide.html#s5.3-camel-case)
  • the identifiers for all model elements start with a capital letter except for properties
  • the identifier for properties starts with a small letter
  • all model elements at least contain the fields "preferred name" and "description" in English language. The description must be comprehensible. It is not required to write full sentences but style should be consistent over the whole model
  • Property and the referenced Characteristic should not have the same name
  • the versioning in the URN follows semantic versioning, where minor version bumps are backwards compatible and major version bumps are not backwards compatible.
  • use abbreviations only when necessary and if these are sufficiently common
  • avoid redundant prefixes in property names (consider adding properties to an enclosing Entity or even adapt the namespace of the model elements, e.g., instead of having two properties DismantlerId and DismantlerName use an Entity Dismantler with the properties name and id or use a URN like io.catenax.dismantler:0.0.1)
  • fields preferredName and description are not the same
  • preferredName should be human readable and follow normal orthography (e.g., no camel case but normal word separation)
  • name of aspect is singular except if it only has one property which is a Collection, List or Set. In theses cases, the aspect name is plural.
  • units are referenced from the SAMM unit catalog whenever possible
  • use constraints to make known constraints from the use case explicit in the aspect model
  • when relying on external standards, they are referenced through a "see" element
  • all properties with an simple type have an example value
  • metadata.json exists with status "release"
  • generated json schema validates against example json payload
  • file RELEASE_NOTES.md exists and contains entries for proposed model changes
  • all contributors to this model are mentioned in copyright header of model file

MS3 Criteria

(to be filled out by semantic modeling team before merge to main-branch)

  • All required reviewers have approved this PR (see reviewers section)
  • The new aspect (version) will be implemented by at least one data provider
  • The new aspect (version) will be consumed by at least one data consumer
  • There exists valid test data
  • In case of a new (incompatible) major version to an existing version, a migration strategy has been developed
  • The model has at least version '1.0.0'
  • If a previous model exists, model deprecation has been checked for previous model
  • The release date in the Release Note is set to the date of the MS3 approval

agg3fe
agg3fe reviewed Nov 19, 2023
View reviewed changes
io.catenax.refurbishing_certificate/2.0.0/RefurbishingCertificate.ttl Outdated
@prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> .
@prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> .
@prefix xsd: <http://www.w3.org/2001/XMLSchema#> .
@prefix : <urn:samm:io.catenax.refurbishing_certificate:1.0.0#> .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as this is version 2.0.0, please change it from 1.0.0 to 2.0.0

agg3fe
agg3fe reviewed Nov 19, 2023
View reviewed changes
io.catenax.refurbishing_certificate/2.0.0/RefurbishingCertificate.ttl Outdated
@prefix xsd: <http://www.w3.org/2001/XMLSchema#> .
@prefix : <urn:samm:io.catenax.refurbishing_certificate:1.0.0#> .
@prefix ext-certificate: <urn:samm:io.catenax.shared.recycling_strategy_certificate:2.0.0#> .
@prefix shared: <urn:samm:io.catenax.shared.recycling_strategy_certificate:1.0.0#> .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this shared prefix used anywhere in model? I do not see any usage of it. you can remove this statement.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, not any more, thanks.

@agg3fe
Copy link
Contributor

agg3fe commented Nov 19, 2023

@yuchengluo1 please rebase you PR with latest code from main branch. You need to include recycling_strategy_certificate:2.0.0 model in your PR. Then it should be able to validate itself.

@github-actions GitHub Actions
Copy link

Validation Report for io.catenax.refurbishing_certificate/2.0.0/RefurbishingCertificate.ttl

Input model is valid

agg3fe
agg3fe reviewed Nov 21, 2023
View reviewed changes
io.catenax.refurbishing_certificate/RELEASE_NOTES.md Outdated
@@ -3,6 +3,16 @@ All notable changes to this model will be documented in this file.

## [Unreleased]

## [2.0.0] - 2023-11-20
### Added
- Upgarde from BAMM model to SAMM model
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo Upgarde

agg3fe
agg3fe requested changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@agg3fe agg3fe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check my comments

agg3fe
agg3fe reviewed Nov 21, 2023
View reviewed changes
io.catenax.refurbishing_certificate/2.0.0/RefurbishingCertificate.ttl Outdated

:certificate a samm:Property ;
samm:preferredName "Certificate"@en ;
samm:description "A property of the model, named "certificate"."@en ;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove double quotes from "certificate", or make it inside single quotes, as the validation is failing because of it.

@github-actions GitHub Actions
Copy link

Validation Report for io.catenax.refurbishing_certificate/2.0.0/RefurbishingCertificate.ttl

Input model is valid

agg3fe
agg3fe approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@agg3fe agg3fe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agg3fe agg3fe added the MS2_Approved Checklist "MS2 Valid Model" is approved. label Nov 23, 2023
@github-actions GitHub Actions
Copy link

Validation Report for io.catenax.refurbishing_certificate/2.0.0/RefurbishingCertificate.ttl

Input model is valid

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

Validation Report for io.catenax.refurbishing_certificate/2.0.0/RefurbishingCertificate.ttl

Input model is valid

@agg3fe agg3fe added the MS3_Approved Checklist "MS3 Release Model" is approved. The associated pull request can be merged to the "main-br label Dec 4, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

Validation Report for io.catenax.refurbishing_certificate/2.0.0/RefurbishingCertificate.ttl

Input model is valid

@agg3fe agg3fe merged commit 8bd7bb3 into eclipse-tractusx:main Dec 11, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agg3fe agg3fe agg3fe approved these changes

Assignees
No one assigned
Labels
MS2_Approved Checklist "MS2 Valid Model" is approved. MS3_Approved Checklist "MS3 Release Model" is approved. The associated pull request can be merged to the "main-br
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Model Update]: Refurbishing Certificate v2.0.0
2 participants
@yuchengluo1 @agg3fe