-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update IotSensorData #450
Update IotSensorData #450
Conversation
modeling_team |
Validation Report for io.catenax.iot_sensor_data/2.0.0/IotSensorData.ttlInput model is valid |
Adjusted to use the shared aspect for UUID.
Validation Report for io.catenax.iot_sensor_data/2.0.0/IotSensorData.ttlInput model is valid |
:sensorUnit a samm:Property ; | ||
samm:preferredName "Sensor Unit"@en ; | ||
samm:characteristic samm-c:UnitReference ; | ||
samm:exampleValue "Celsius"^^samm:curie . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The correct example value should be unit: Celsius
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, my mistake. value should be without any space. unit:Celsius
example value changed to: unit: Celsius
Validation Report for io.catenax.iot_sensor_data/2.0.0/IotSensorData.ttlInput model is valid |
samm:description "Characteristic describing the property altitude."@en ; | ||
samm:dataType xsd:decimal . | ||
|
||
:SensorValueCharacteristics a samm:Characteristic ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please also provide preferredName
here
@@ -3,6 +3,15 @@ All notable changes to this model will be documented in this file. | |||
|
|||
## [Unreleased] | |||
|
|||
## [2.0.0] - 2023-11-13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can also change the date here to 20th for MS3 approval.
Validation Report for io.catenax.iot_sensor_data/2.0.0/IotSensorData.ttlInput model is valid |
prefered name added.
Validation Report for io.catenax.iot_sensor_data/2.0.0/IotSensorData.ttlInput model is valid |
Release Date changed.
Validation Report for io.catenax.iot_sensor_data/2.0.0/IotSensorData.ttlInput model is valid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added "see" links for GeoData
Validation Report for io.catenax.iot_sensor_data/2.0.0/IotSensorData.ttlInput model is valid |
Description
-->
Ex. json:
Closes #427
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)