-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update IotSensorDeviceDefinition v.2.0.0 #448
Update IotSensorDeviceDefinition v.2.0.0 #448
Conversation
Conversion from SAMM to BAMM
Validation Report for io.catenax.iot_sensor_device_definition/2.0.0/IotSensorDeviceDefinition.ttlInput model is valid |
modeling_team |
:catenaXId a samm:Property ; | ||
samm:preferredName "Catena-X Identifier"@en ; | ||
samm:description "The fully anonymous Catena-X ID of the serialized part, valid for the Catena-X dataspace."@en ; | ||
samm:characteristic :CatenaXIdTrait ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here also you can make use of existing characteristic and don't need to define a new one.
For reference: https://github.com/eclipse-tractusx/sldt-semantic-models/pull/405/files#diff-8294717bc9be9d276f548ae9f83e2831503589ef17d4d5bf6f1463cdb397d00eR45
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Thank you for the hint!
:ownerID a samm:Property ; | ||
samm:preferredName "IoT Sensor Device Owner"@en ; | ||
samm:description "The Catena-X BPNL of the device owner."@en ; | ||
samm:characteristic :OwnerIDCharacteristic ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if BPNL is the only allowed value, You can make use of existing characteristic and don't need to define a new one.
For reference: https://github.com/eclipse-tractusx/sldt-semantic-models/pull/405/files#diff-8294717bc9be9d276f548ae9f83e2831503589ef17d4d5bf6f1463cdb397d00eR104
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Thank you for the hint!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check my comments
Adjusted to use the shared aspects for BPNL and UUID.
Validation Report for io.catenax.iot_sensor_device_definition/2.0.0/IotSensorDeviceDefinition.ttlInput model is valid |
@agg3fe requested changes are done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Cvetanka-ZF Thanks. I have assigned MS2 approval. Finally you can change the date in release notes, so that we can do the MS3 on Monday. |
@@ -2,13 +2,18 @@ | |||
All notable changes to this model will be documented in this file. | |||
|
|||
## [Unreleased] | |||
## [2.0.0] - 2023-11-13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change the date to 2023-11-20
Validation Report for io.catenax.iot_sensor_device_definition/2.0.0/IotSensorDeviceDefinition.ttlInput model is valid |
Description
-->
Closes #428
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)