-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Model]: Shared Aspect for BPN #297
Merged
bs-jokri
merged 3 commits into
eclipse-tractusx:main
from
tom-rm-meyer-ISST:feat/shared-bpns
Sep 18, 2023
Merged
[New Model]: Shared Aspect for BPN #297
bs-jokri
merged 3 commits into
eclipse-tractusx:main
from
tom-rm-meyer-ISST:feat/shared-bpns
Sep 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Validation Report for io.catenax.shared.uuid/1.0.0/Uuid.ttlInput model is valid |
Validation Report for io.catenax.planned_production_output/1.0.0/PlannedProductionOutput.ttlInput model is valid |
Validation Report for io.catenax.shared.business_partner_number/1.0.0/BusinessPartnerNumber.ttlInput model is valid |
tom-rm-meyer-ISST
force-pushed
the
feat/shared-bpns
branch
from
September 5, 2023 05:25
f3a4dea
to
6d2e0fc
Compare
tom-rm-meyer-ISST
force-pushed
the
feat/shared-bpns
branch
from
September 5, 2023 05:29
6d2e0fc
to
d3fd27f
Compare
Validation Report for io.catenax.shared.business_partner_number/1.0.0/BusinessPartnerNumber.ttlInput model is valid |
agg3fe
reviewed
Sep 6, 2023
io.catenax.shared.business_partner_number/1.0.0/BusinessPartnerNumber.ttl
Outdated
Show resolved
Hide resolved
Validation Report for io.catenax.shared.business_partner_number/1.0.0/BusinessPartnerNumber.ttlInput model is valid |
agg3fe
reviewed
Sep 6, 2023
io.catenax.shared.business_partner_number/1.0.0/BusinessPartnerNumber.ttl
Outdated
Show resolved
Hide resolved
bs-jokri
reviewed
Sep 6, 2023
io.catenax.shared.business_partner_number/1.0.0/BusinessPartnerNumber.ttl
Outdated
Show resolved
Hide resolved
Validation Report for io.catenax.shared.business_partner_number/1.0.0/BusinessPartnerNumber.ttlInput model is valid |
agg3fe
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Sep 11, 2023
bs-jokri
added
the
MS3_Approved
Checklist "MS3 Release Model" is approved. The associated pull request can be merged to the "main-br
label
Sep 11, 2023
@bs-jokri: Do we have outstanding points upfront of merging? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
MS2_Approved
Checklist "MS2 Valid Model" is approved.
MS3_Approved
Checklist "MS3 Release Model" is approved. The associated pull request can be merged to the "main-br
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As proposed in the review of PR #295 , I created the MS2 first. MS1 will be added afterwards, so that we can directly do the MS3 next week.
Instead of just proposing BPNS, I propose them all with characteristic definitions from the standard document.
Closes #302
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)