-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Follow up SingleLevelUsageAsBuilt_2.0.0 #287
Follow up SingleLevelUsageAsBuilt_2.0.0 #287
Conversation
Created ttl-file based 1:1 on existing SingleLevelUsageAsBuilt.ttl from the branch single_level_usage_as_built_2.0.0 of the fork jacewski-bosch/sldt-semantic-models
Created notes.md File based 1:1 on the existing RELEASE_NOTES.md from the branch single_level_usage_as_built_2.0.0 of the fork jacewski-bosch/sldt-semantic-models
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
- | Generic Password | e6d299e | io.catenax.single_level_usage_as_built/2.0.0/.log/debug.log | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
@johannsvarela please remove the .log folder from the PR, this seems to be mistakenly added to the PR. After that we should be good to go for MS2 -> just removed the log file on my own. Hope this is ok. So nothing to do from your side anymore here. |
modeling_team |
@johannsvarela @BenediktMuellerIML the following two MS3 approval conditionally provided given
No further presentation of the model is required. @johannsvarela @BenediktMuellerIML provide a comment as soon as the issues are resolved and the MS3 approval will be given. |
@bs-jokri there are some updates regarding the missing points for the MS3 approval:
|
Description
Since the colleague jacewski-bosch is on parental leave, we aren't able to update the exsting PR #198.
Therefore we created a new PR based 1:1 on the existing PR #198 with the original content of the branch single_level_usage_as_built_2.0.0 from the fork jacewski-bosch/sldt-semantic-models to be able to continue the MS approval check.
Closes #198 and #196.
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)