-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model Update] Digital Product Passport 2.0.0 #283
Conversation
Modeling_Team |
@bs-jokri please check this: |
@bs-jokri ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I found some smaller things, which you might fix. also there is a problem with the sam:curie validation, which I am currently investigating
io.catenax.generic.digital_product_passport/2.0.0/DigitalProductPassport.ttl
Outdated
Show resolved
Hide resolved
io.catenax.generic.digital_product_passport/2.0.0/DigitalProductPassport.ttl
Outdated
Show resolved
Hide resolved
io.catenax.generic.digital_product_passport/2.0.0/DigitalProductPassport.ttl
Outdated
Show resolved
Hide resolved
io.catenax.generic.digital_product_passport/2.0.0/DigitalProductPassport.ttl
Outdated
Show resolved
Hide resolved
io.catenax.generic.digital_product_passport/2.0.0/DigitalProductPassport.ttl
Show resolved
Hide resolved
io.catenax.generic.digital_product_passport/2.0.0/DigitalProductPassport.ttl
Show resolved
Hide resolved
io.catenax.generic.digital_product_passport/2.0.0/DigitalProductPassport.ttl
Outdated
Show resolved
Hide resolved
- structure for concentration changed - changed optional attributes - changed some inputs to: either not applicable or a mandatory input
@bs-jokri payload is valid against the schema. Checked without cli (because it can't generate the files). |
io.catenax.generic.digital_product_passport/2.0.0/DigitalProductPassport.ttl
Outdated
Show resolved
Hide resolved
curie to string see links added id and name for material to list
@bs-jokri |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to resolve the datetime example payload issue first
io.catenax.generic.digital_product_passport/2.0.0/DigitalProductPassport.ttl
Outdated
Show resolved
Hide resolved
yes I did do so, but I thought it was fixed in this version as mentioned in the release notes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
added preferredName and description
MS3 approval will be given and model will be released. However, the PCF model and the Environmental Footprint Characteristic need to be harmonized. Follow up discussions with PCF use case need to initiated. @catroest |
@catroest i See still activities on this PR. Do you ping me, when I can merge? |
Description
Release 23.12/Version 2.0: This data model is based on the proposed Ecodesign Regulation ("Proposal for a REGULATION OF THE EUROPEAN PARLIAMENT AND OF THE COUNCIL establishing a framework for setting ecodesign requirements for sustainable products and repealing Directive 2009/125/EC" ESPR from March 30th, 2022 with some additional data points which can be found in the adopted Amendments from July 12th 2023 (Amendments adopted by the European Parliament on 12 July 2023 on the proposal for a regulation of the European Parliament and of the Council establishing a framework for setting eco-design requirements for sustainable products and repealing Directive 2009/125/EC).
Closes #260
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)