Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model Update]: SingleLevelBomAsSpecified #274
[Model Update]: SingleLevelBomAsSpecified #274
Changes from 2 commits
7f40719
d297efc
48f0536
bd728e9
68a0792
dd128b6
4ae8fbf
4a71fe4
aa67f87
ef62a3b
edd6eb3
65450f3
50a9925
2149f07
f9f1260
0e344ff
0286b39
fddfb9e
93ab4f6
5c13485
886cd8f
24958a5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SAMM meta model is default since 7.7.2023. We should migrate the model to samm prior release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems the document is not saved with uff-8 encoding. would it be possible to resave in utf-8. Otherwise special characters like the quotation marks are not processed properly. BTW quotation marks can be escaped with a \ in the description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depending on how the model is supposed to be used, the whitespaces in the enumeration values could be a source of error, if they are used in comparisons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you mean 2.0.0