-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Model] Message Header (Shared Aspect Model) #227
[New Model] Message Header (Shared Aspect Model) #227
Conversation
Validation Report for io.catenax.message_header/1.0.0/MessageHeaderAspect.ttlValidation failed: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check my comments
replaces #128 |
Validation Report for io.catenax.message_header/1.0.0/MessageHeaderAspect.ttlValidation failed: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check comment regarding shared namespace
For MS2 approval missing
|
@ Sahil you need to take over here |
Validation Report for io.catenax.message_header/1.0.0/MessageHeaderAspect.ttlValidation failed: |
Validation Report for io.catenax.shared.message_header/1.0.0/MessageHeaderAspect.ttlValidation failed: |
Validation Report for io.catenax.shared.message_header/1.0.0/MessageHeaderAspect.ttlValidation failed: |
Modelling_Team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dominikoeh Here are the proposals for extended field descriptions we talked about last Friday.
Improves descriptions of the message header's fields regarding the context and versioning
Validation Report for io.catenax.shared.message_header/1.0.0/MessageHeaderAspect.ttlValidation failed: |
Validation Report for io.catenax.shared.message_header/1.0.0/MessageHeaderAspect.ttlValidation failed: |
modeling_team |
MS2 + MS3 approval given by group |
Description
This model has been created to replace the current proposal of the implementation of the Notification Header (#128).
The implementation is in line with the latest changes proposed for interoperability cf. confluence
Closes #115
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)