Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Model] Message Header (Shared Aspect Model) #227

Merged
merged 8 commits into from
Aug 14, 2023
Merged

[New Model] Message Header (Shared Aspect Model) #227

merged 8 commits into from
Aug 14, 2023

Conversation

dominikoeh
Copy link
Contributor

@dominikoeh dominikoeh commented Jul 5, 2023

Description

This model has been created to replace the current proposal of the implementation of the Notification Header (#128).

The implementation is in line with the latest changes proposed for interoperability cf. confluence

Closes #115

MS2 Criteria

(to be filled out by PR reviewer)

  • the model validates with the BAMM SDS SDK in the version specified in the Readme.md of this repository by the time of the MS2 check (e.g., 'java -jar bamm-cli.jar -i <path-to-aspect-model> -v ). The BAMM CLI is available here and in GitHub
  • use Camel-Case (e.g., "MyModelElement" or "TimeDifferenceGmtId", when in doubt follow https://google.github.io/styleguide/javaguide.html#s5.3-camel-case)
  • the identifiers for all model elements start with a capital letter except for properties
  • the identifier for properties starts with a small letter
  • all model elements at least contain the fields "preferred name" and "description" in English language. The description must be comprehensible. It is not required to write full sentences but style should be consistent over the whole model
  • Property and the referenced Characteristic should not have the same name
  • the versioning in the URN follows semantic versioning, where minor version bumps are backwards compatible and major version bumps are not backwards compatible.
  • use abbreviations only when necessary and if these are sufficiently common
  • avoid redundant prefixes in property names (consider adding properties to an enclosing Entity or even adapt the namespace of the model elements, e.g., instead of having two properties DismantlerId and DismantlerName use an Entity Dismantler with the properties name and id or use a URN like io.catenax.dismantler:0.0.1)
  • fields preferredName and description are not the same
  • preferredName should be human readable and follow normal orthography (e.g., no camel case but normal word separation)
  • name of aspect is singular except if it only has one property which is a Collection, List or Set. In theses cases, the aspect name is plural.
  • units are referenced from the BAMM unit catalog whenever possible
  • use constraints to make known constraints from the use case explicit in the aspect model
  • when relying on external standards, they are referenced through a "see" element
  • all properties with an simple type have an example value
  • metadata.json exists with status "release"
  • generated json schema validates against example json payload
  • file RELEASE_NOTES.md exists and contains entries for proposed model changes
  • all contributors to this model are mentioned in copyright header of model file

MS3 Criteria

(to be filled out by semantic modeling team before merge to main-branch)

  • All required reviewers have approved this PR (see reviewers section)
  • The new aspect (version) will be implemented by at least one data provider
  • The new aspect (version) will be consumed by at least one data consumer
  • There exists valid test data
  • In case of a new (incompatible) major version to an existing version, a migration strategy has been developed
  • The model has at least version '1.0.0'
  • The release date in the Release Note is set to the date of the MS3 approval

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Validation Report for io.catenax.message_header/1.0.0/MessageHeaderAspect.ttl

Validation failed:

Copy link
Contributor

@bs-jokri bs-jokri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check my comments

io.catenax.message_header/1.0.0/MessageHeaderAspect.ttl Outdated Show resolved Hide resolved
io.catenax.message_header/1.0.0/MessageHeaderAspect.ttl Outdated Show resolved Hide resolved
io.catenax.message_header/1.0.0/MessageHeaderAspect.ttl Outdated Show resolved Hide resolved
io.catenax.message_header/1.0.0/MessageHeaderAspect.ttl Outdated Show resolved Hide resolved
io.catenax.message_header/1.0.0/MessageHeaderAspect.ttl Outdated Show resolved Hide resolved
io.catenax.message_header/1.0.0/MessageHeaderAspect.ttl Outdated Show resolved Hide resolved
io.catenax.message_header/1.0.0/MessageHeaderAspect.ttl Outdated Show resolved Hide resolved
io.catenax.message_header/1.0.0/MessageHeaderAspect.ttl Outdated Show resolved Hide resolved
io.catenax.message_header/1.0.0/MessageHeaderAspect.ttl Outdated Show resolved Hide resolved
io.catenax.message_header/RELEASE_NOTES.md Outdated Show resolved Hide resolved
@bs-jokri
Copy link
Contributor

bs-jokri commented Jul 6, 2023

replaces #128

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Validation Report for io.catenax.message_header/1.0.0/MessageHeaderAspect.ttl

Validation failed:

Copy link
Contributor

@bs-jokri bs-jokri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check comment regarding shared namespace

io.catenax.message_header/1.0.0/MessageHeaderAspect.ttl Outdated Show resolved Hide resolved
@bs-jokri
Copy link
Contributor

For MS2 approval missing

  1. license header
  2. move to shared namespace
  3. responding to review comments (either fixing if appropriate or justify why not)

@bs-jokri
Copy link
Contributor

bs-jokri commented Jul 14, 2023

@ Sahil you need to take over here

@github-actions
Copy link

Validation Report for io.catenax.message_header/1.0.0/MessageHeaderAspect.ttl

Validation failed:

@github-actions
Copy link

Validation Report for io.catenax.shared.message_header/1.0.0/MessageHeaderAspect.ttl

Validation failed:

@github-actions
Copy link

Validation Report for io.catenax.shared.message_header/1.0.0/MessageHeaderAspect.ttl

Validation failed:

@dominikoeh
Copy link
Contributor Author

Modelling_Team

@petyog petyog added the Modeling Team This issue or PR should be discussed in the modeling team. label Jul 29, 2023
Copy link
Contributor

@petyog petyog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dominikoeh Here are the proposals for extended field descriptions we talked about last Friday.

Improves descriptions of the message header's fields regarding the
context and versioning
@github-actions
Copy link

Validation Report for io.catenax.shared.message_header/1.0.0/MessageHeaderAspect.ttl

Validation failed:

@github-actions
Copy link

Validation Report for io.catenax.shared.message_header/1.0.0/MessageHeaderAspect.ttl

Validation failed:

@dominikoeh
Copy link
Contributor Author

modeling_team

@bosserf
Copy link

bosserf commented Jul 31, 2023

MS2 + MS3 approval given by group

@bs-jokri bs-jokri added MS2_Approved Checklist "MS2 Valid Model" is approved. MS3_Approved Checklist "MS3 Release Model" is approved. The associated pull request can be merged to the "main-br labels Aug 8, 2023
@bs-jokri bs-jokri merged commit 84afe62 into eclipse-tractusx:main Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Modeling Team This issue or PR should be discussed in the modeling team. MS2_Approved Checklist "MS2 Valid Model" is approved. MS3_Approved Checklist "MS3 Release Model" is approved. The associated pull request can be merged to the "main-br
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Model]: Shared Model for Notification Header
5 participants