Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User estimated loading patch 1 #199

Merged

Conversation

JuttaRoh
Copy link
Contributor

@JuttaRoh JuttaRoh commented Jun 14, 2023

Description

-->

Closes #

MS2 Criteria

(to be filled out by PR reviewer)

  • the model validates with the BAMM SDS SDK in the version specified in the Readme.md of this repository by the time of the MS2 check (e.g., 'java -jar bamm-cli.jar -i <path-to-aspect-model> -v ). The BAMM CLI is available here and in GitHub
  • use Camel-Case (e.g., "MyModelElement" or "TimeDifferenceGmtId", when in doubt follow https://google.github.io/styleguide/javaguide.html#s5.3-camel-case)
  • the identifiers for all model elements start with a capital letter except for properties
  • the identifier for properties starts with a small letter
  • all model elements at least contain the fields "name" and "description" in English language.
  • no duplicate names or preferredNames within an Aspect (e.g. a Property and the referenced Characteristic should not have the same name)
  • the versioning in the URN follows semantic versioning, where minor version bumps are backwards compatible and major version bumps are not backwards compatible.
  • use abbreviations only when necessary and if these are sufficiently common
  • avoid redundant prefixes in property names (consider adding properties to an enclosing Entity or even adapt the namespace of the model elements, e.g., instead of having two properties DismantlerId and DismantlerName use an Entity Dismantler with the properties name and id or use a URN like io.catenax.dismantler:0.0.1)
  • fields preferredName and description are not the same
  • preferredName should be human readable and follow normal orthography (e.g., no camel case but normal word separation)
  • name of aspect is singular except if it only has one property which is a Collection, List or Set. In theses cases, the aspect name is plural.
  • units are referenced from the BAMM unit catalog whenever possible
  • use constraints to make known constraints from the use case explicit in the aspect model
  • when relying on external standards, they are referenced through a "see" element
  • all properties with an simple type have an example value
  • metadata.json exists with status "release"
  • file RELEASE_NOTES.md exists and contains entries for proposed model changes
  • all contributors to this model are mentioned in copyright header of model file

MS3 Criteria

(to be filled out by semantic modeling team before merge to main-branch)

  • All required reviewers have approved this PR (see reviewers section)
  • The new aspect (version) will be implemented by at least one data provider
  • The new aspect (version) will be consumed by at least one data consumer
  • There exists valid test data
  • In case of a new (incompatible) major version to an existing version, a migration strategy has been developed
  • The model has at least version '1.0.0'

JuttaRoh added 7 commits May 24, 2023 16:44
-namespace fixed
-BAMM 2.0.0 instead of SAMM 2.0.0
-whitespaces removed
-description added
-uppercase letters 
-renamed futureListEntity to futureScenarioEntity
-reference links included
-type info corrected
@github-actions
Copy link

Validation Report for io.catenax.user_estimated_loading/1.0.0/UserEstimatedLoading.ttl

Syntax error in line 144, column 41: Datatype URI required after ^^ - URI or prefixed name expected

  139: 
  140: :trailerUse a bamm:Property ;
  141:    bamm:preferredName "Trailer use switch"@en ;
  142:    bamm:description "Usage of trailer like caravan. "@en ;
  143:    bamm:characteristic :Boolean ;
->144:    bamm:exampleValue "true"^^xsd.boolean .
  145: 
  146: :cityDriving a bamm:Property ;
  147:    bamm:preferredName "City driving switch"@en ;
  148:    bamm:description "City driving means a short distances."@en ;
  149:    bamm:characteristic :Boolean ;

syntax error corrected
@github-actions
Copy link

Validation Report for io.catenax.user_estimated_loading/1.0.0/UserEstimatedLoading.ttl

Semantic violations were found:

> :futureScenario :
  Property bamm:characteristic on :futureScenario has type urn:sbamm:io.openmanufacturing:characteristic:2.0.0#Collection, but only bamm:Characteristic is allowed.

> :future :
  Property bamm:characteristic on :future has type urn:sbamm:io.openmanufacturing:characteristic:2.0.0#List, but only bamm:Characteristic is allowed.

> :powerKW :
  Property bamm:characteristic on :powerKW has type urn:sbamm:io.openmanufacturing:characteristic:2.0.0#Measurement, but only bamm:Characteristic is allowed.

> :ageInMonth :
  Property bamm:characteristic on :ageInMonth has type urn:sbamm:io.openmanufacturing:characteristic:2.0.0#Duration, but only bamm:Characteristic is allowed.

> :mileage :
  Property bamm:characteristic on :mileage has type urn:sbamm:io.openmanufacturing:characteristic:2.0.0#Measurement, but only bamm:Characteristic is allowed.

> :vehicleType :
  Property bamm:characteristic on :vehicleType has type urn:sbamm:io.openmanufacturing:characteristic:2.0.0#Enumeration, but only bamm:Characteristic is allowed.

> :grossVehicleWeightKG :
  Property bamm:characteristic on :grossVehicleWeightKG has type urn:sbamm:io.openmanufacturing:characteristic:2.0.0#Measurement, but only bamm:Characteristic is allowed.

> :energySourceCode :
  Property bamm:characteristic on :energySourceCode has type urn:sbamm:io.openmanufacturing:characteristic:2.0.0#Enumeration, but only bamm:Characteristic is allowed.

> :cityDriving :
  The datatype (see value) of the exampleValue neither matches nor can be cast to the Property's (see focusNode) Characteristic's dataType.

> :history :
  Property bamm:characteristic on :history has type urn:sbamm:io.openmanufacturing:characteristic:2.0.0#List, but only bamm:Characteristic is allowed.

@github-actions
Copy link

Validation Report for io.catenax.user_estimated_loading/1.0.0/UserEstimatedLoading.ttl

Semantic violations were found:

> :cityDriving :
  The datatype (see value) of the exampleValue neither matches nor can be cast to the Property's (see focusNode) Characteristic's dataType.

Copy link
Contributor

@bs-jokri bs-jokri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the boolean reference issue. afterwards it should validate and looks good

characteristic bamm  -> bamm-c 
whitespaces removed
Copy link
Contributor

@bs-jokri bs-jokri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

Validation Report for io.catenax.user_estimated_loading/1.0.0/UserEstimatedLoading.ttl

Input model is valid

@bs-jokri
Copy link
Contributor

bs-jokri commented Jun 26, 2023

Before release

  • check if date in copyright header is correct
  • adjust release date to date of ms3 approval

@bs-jokri bs-jokri added the MS3_Approved Checklist "MS3 Release Model" is approved. The associated pull request can be merged to the "main-br label Jun 26, 2023
@bs-jokri bs-jokri added the MS2_Approved Checklist "MS2 Valid Model" is approved. label Jun 28, 2023
@github-actions
Copy link

Validation Report for io.catenax.user_estimated_loading/1.0.0/UserEstimatedLoading.ttl

Input model is valid

@bs-jokri bs-jokri merged commit 6beafa3 into eclipse-tractusx:main Jun 28, 2023
@bs-jokri bs-jokri mentioned this pull request Jul 6, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MS2_Approved Checklist "MS2 Valid Model" is approved. MS3_Approved Checklist "MS3 Release Model" is approved. The associated pull request can be merged to the "main-br
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants