-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User estimated loading patch 1 #199
Merged
bs-jokri
merged 13 commits into
eclipse-tractusx:main
from
JuttaRoh:user_estimated_loading-patch-1
Jun 28, 2023
Merged
User estimated loading patch 1 #199
bs-jokri
merged 13 commits into
eclipse-tractusx:main
from
JuttaRoh:user_estimated_loading-patch-1
Jun 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-namespace fixed -BAMM 2.0.0 instead of SAMM 2.0.0 -whitespaces removed -description added -uppercase letters -renamed futureListEntity to futureScenarioEntity -reference links included -type info corrected
Validation Report for io.catenax.user_estimated_loading/1.0.0/UserEstimatedLoading.ttlSyntax error in line 144, column 41: Datatype URI required after ^^ - URI or prefixed name expected 139:
140: :trailerUse a bamm:Property ;
141: bamm:preferredName "Trailer use switch"@en ;
142: bamm:description "Usage of trailer like caravan. "@en ;
143: bamm:characteristic :Boolean ;
->144: bamm:exampleValue "true"^^xsd.boolean .
145:
146: :cityDriving a bamm:Property ;
147: bamm:preferredName "City driving switch"@en ;
148: bamm:description "City driving means a short distances."@en ;
149: bamm:characteristic :Boolean ; |
syntax error corrected
Validation Report for io.catenax.user_estimated_loading/1.0.0/UserEstimatedLoading.ttlSemantic violations were found:> :futureScenario :
Property bamm:characteristic on :futureScenario has type urn:sbamm:io.openmanufacturing:characteristic:2.0.0#Collection, but only bamm:Characteristic is allowed.
> :future :
Property bamm:characteristic on :future has type urn:sbamm:io.openmanufacturing:characteristic:2.0.0#List, but only bamm:Characteristic is allowed.
> :powerKW :
Property bamm:characteristic on :powerKW has type urn:sbamm:io.openmanufacturing:characteristic:2.0.0#Measurement, but only bamm:Characteristic is allowed.
> :ageInMonth :
Property bamm:characteristic on :ageInMonth has type urn:sbamm:io.openmanufacturing:characteristic:2.0.0#Duration, but only bamm:Characteristic is allowed.
> :mileage :
Property bamm:characteristic on :mileage has type urn:sbamm:io.openmanufacturing:characteristic:2.0.0#Measurement, but only bamm:Characteristic is allowed.
> :vehicleType :
Property bamm:characteristic on :vehicleType has type urn:sbamm:io.openmanufacturing:characteristic:2.0.0#Enumeration, but only bamm:Characteristic is allowed.
> :grossVehicleWeightKG :
Property bamm:characteristic on :grossVehicleWeightKG has type urn:sbamm:io.openmanufacturing:characteristic:2.0.0#Measurement, but only bamm:Characteristic is allowed.
> :energySourceCode :
Property bamm:characteristic on :energySourceCode has type urn:sbamm:io.openmanufacturing:characteristic:2.0.0#Enumeration, but only bamm:Characteristic is allowed.
> :cityDriving :
The datatype (see value) of the exampleValue neither matches nor can be cast to the Property's (see focusNode) Characteristic's dataType.
> :history :
Property bamm:characteristic on :history has type urn:sbamm:io.openmanufacturing:characteristic:2.0.0#List, but only bamm:Characteristic is allowed. |
Validation Report for io.catenax.user_estimated_loading/1.0.0/UserEstimatedLoading.ttlSemantic violations were found:> :cityDriving :
The datatype (see value) of the exampleValue neither matches nor can be cast to the Property's (see focusNode) Characteristic's dataType. |
bs-jokri
suggested changes
Jun 20, 2023
io.catenax.user_estimated_loading/1.0.0/UserEstimatedLoading.ttl
Outdated
Show resolved
Hide resolved
data typ corrected
bs-jokri
suggested changes
Jun 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix the boolean reference issue. afterwards it should validate and looks good
io.catenax.user_estimated_loading/1.0.0/UserEstimatedLoading.ttl
Outdated
Show resolved
Hide resolved
io.catenax.user_estimated_loading/1.0.0/UserEstimatedLoading.ttl
Outdated
Show resolved
Hide resolved
io.catenax.user_estimated_loading/1.0.0/UserEstimatedLoading.ttl
Outdated
Show resolved
Hide resolved
characteristic bamm -> bamm-c whitespaces removed
bs-jokri
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Validation Report for io.catenax.user_estimated_loading/1.0.0/UserEstimatedLoading.ttlInput model is valid |
Before release
|
bs-jokri
added
the
MS3_Approved
Checklist "MS3 Release Model" is approved. The associated pull request can be merged to the "main-br
label
Jun 26, 2023
Validation Report for io.catenax.user_estimated_loading/1.0.0/UserEstimatedLoading.ttlInput model is valid |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
MS2_Approved
Checklist "MS2 Valid Model" is approved.
MS3_Approved
Checklist "MS3 Release Model" is approved. The associated pull request can be merged to the "main-br
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
-->
Closes #
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)