-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single level bom as built 1.0.0 #185
Merged
bs-jokri
merged 14 commits into
eclipse-tractusx:main
from
jacewski-bosch:single-level-bom-as-built-1.0.0
Jun 14, 2023
Merged
Single level bom as built 1.0.0 #185
bs-jokri
merged 14 commits into
eclipse-tractusx:main
from
jacewski-bosch:single-level-bom-as-built-1.0.0
Jun 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated to samm 2.0.0, changed childParts to childItems and childCatenaXId to catenaXId to conform with data chain standard, updated copyright, improved naming for some elements
made BPN RegEx only accept BPNL
bs-jokri
suggested changes
May 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check my comments
io.catenax.single_level_bom_as_built/1.0.0/SingleLevelBomAsBuilt.ttl
Outdated
Show resolved
Hide resolved
io.catenax.single_level_bom_as_built/1.0.0/SingleLevelBomAsBuilt.ttl
Outdated
Show resolved
Hide resolved
replaced occurences of `part` with `item` where applicable
removed life cycle context property from child item
removed wrongly comitted file
bs-jokri
added
the
MS3_Approved
Checklist "MS3 Release Model" is approved. The associated pull request can be merged to the "main-br
label
Jun 12, 2023
SAMM meta model will be change to BAMM 2.0.0 prior release |
Validation Report for io.catenax.single_level_bom_as_built/1.0.0/SingleLevelBomAsBuilt.ttlInput model is valid |
Validation Report for io.catenax.single_level_bom_as_built/1.0.0/SingleLevelBomAsBuilt.ttlInput model is valid |
bs-jokri
approved these changes
Jun 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
MS2_Approved
Checklist "MS2 Valid Model" is approved.
MS3_Approved
Checklist "MS3 Release Model" is approved. The associated pull request can be merged to the "main-br
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renamed Aspect for more clarity and following the naming convention as per other tracebility aspects.
Additionally to changes have been introduced with this major update:
Closes #78
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)