-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model-Update] PCF: Update for compatibility with specification WBCSD v2 and PCF Rulebook v2 #182
[Model-Update] PCF: Update for compatibility with specification WBCSD v2 and PCF Rulebook v2 #182
Conversation
@SMaierTSI you might check this issue as it describes how to reference units from the unit catalog in an enum. Maybe this could be applied in your case as well. |
…tibility with the Catena-X PCF Rulebook V2 and the WBCSD (World Business Council for Sustainable Development) specification V2.
@bs-jokri modifications have been implemented as discussed, please check latest version with regards to MS2. |
modeling_team |
@bs-jokri just commited an updated version with some (minor) changes after review with our implementation team experts. Please check the latest version with regards to MS2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some remarks. Check if they apply
Validation Report for io.catenax.pcf/4.0.0/Pcf.ttlValidation failed: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Validation Report for io.catenax.pcf/4.0.0/Pcf.ttlInput model is valid |
pCfIncludingBiogenetic -> C lowercase |
Validation Report for io.catenax.pcf/4.0.0/Pcf.ttlInput model is valid |
Validation Report for io.catenax.pcf/4.0.0/Pcf.ttlInput model is valid |
Description
Implementation of necessary adaptations in order to ensure compatibility of the PCF data model with the current specifications of WBCSD (World Business Council for Sustainable Development) and the PCF Rulebook.
-->
Closes #165
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)