-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model Update] BOM As Specified #151
Conversation
Validation Report for io.catenax.bom_as_specified/1.0.2/SingleLevelBomAsSpecified.ttlValidation failed: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check my comments
io.catenax.bom_as_specified/2.0.0/SingleLevelBomAsSpecified.ttl
Outdated
Show resolved
Hide resolved
io.catenax.bom_as_specified/2.0.0/SingleLevelBomAsSpecified.ttl
Outdated
Show resolved
Hide resolved
io.catenax.bom_as_specified/2.0.0/SingleLevelBomAsSpecified.ttl
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
from discussion: Property "LifecycleContext" might not be required. Further discussion needed. @maxim-bo @BenediktMuellerIML @catroest will discuss how to proceed. |
…ng parties from the other bom areas (asBuilt, asPlanned)
…to initial version but with adjustments for the IRS (i.e. having the childCatenaXId directly under the ChildPartsEntity and not under the PartEntity)
Modeling_Team |
Description
-->
Closes #120
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)