-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add aspect model for Material Flow Simulation Result #135
feat: add aspect model for Material Flow Simulation Result #135
Conversation
adds the initial version of the Material Flow Simulation Result aspect model
use the english name instead of the german
Generated sample data: |
MS2 Criteria
|
@modeling_team Was not applied in the case of other models?
|
modeling_team |
- adds descriptions to the characteristics - adds unique names for each modelling element
|
removes the simulation status from the model
Latest sample data |
In order to make use of a generic site identifier identifying a business partner the BPNS references have been removed
As suggested: BPNS references have been removed from the model in favor of more general site identifiers, |
From MS3 review: Conditionally MS3 approved batch name needs a more concrete description. After adding this MS3 label can be given an model released. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification. LGTM
adds the initial version of the Material Flow Simulation Result aspect model
Description
-->
Closes #133
MS2 Criteria
(to be filled out by PR reviewer)
DismantlerId
andDismantlerName
use an EntityDismantler
with the propertiesname
andid
or use a URN likeio.catenax.dismantler:0.0.1
)preferredName
anddescription
are not the samepreferredName
should be human readable and follow normal orthography (e.g., no camel case but normal word separation)MS3 Criteria
(to be filled out by semantic modeling team before merge to main-branch)