Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license header description to contributing.md #11

Conversation

bs-jokri
Copy link
Contributor

@bs-jokri bs-jokri commented Dec 12, 2022

Signed-off-by: Johannes Kristan [email protected]

Description

Adds a description to contribting.md which license header to add to model files

Closes #

MS2 Criteria

(to be filled out by PR reviewer)

  • the model validates with the BAMM SDS SDK in the version specified in the Readme.md of this repository by the time of the MS2 check (e.g., 'java -jar bamm-cli.jar -i <path-to-aspect-model> -v ). The BAMM CLI is available here and in GitHub
  • use Camel-Case (e.g., "MyModelElement" or "TimeDifferenceGmtId", when in doubt follow https://google.github.io/styleguide/javaguide.html#s5.3-camel-case)
  • the identifiers for all model elements start with a capital letter except for properties
  • the identifier for properties starts with a small letter
  • all model elements at least contain the fields "name" and "description" in English language.
  • no duplicate names or preferredNames within an Aspect (e.g. a Property and the referenced Characteristic should not have the same name)
  • the versioning in the URN follows semantic versioning, where minor version bumps are backwards compatible and major version bumps are not backwards compatible.
  • use abbreviations only when necessary and if these are sufficiently common
  • avoid redundant prefixes in property names (consider adding properties to an enclosing Entity or even adapt the namespace of the model elements, e.g., instead of having two properties DismantlerId and DismantlerName use an Entity Dismantler with the properties name and id or use a URN like io.catenax.dismantler:0.0.1)
  • fields preferredName and description are not the same
  • preferredName should be human readable and follow normal orthography (e.g., no camel case but normal word separation)
  • name of aspect is singular except if it only has one property which is a Collection, List or Set. In theses cases, the aspect name is plural.
  • units are referenced from the BAMM unit catalog whenever possible
  • use constraints to make known constraints from the use case explicit in the aspect model
  • when relying on external standards, they are referenced through a "see" element
  • all properties with an simple type have an example value
  • metadata.json exists with status "release"

MS3 Criteria

(to be filled out by semantic modeling team before merge to main-branch)

  • All required reviewers have approved this PR (see reviewers section)
  • The new aspect (version) will be implemented by at least one data provider
  • The new aspect (version) will be consumed by at least one data consumer
  • There exists valid test data
  • In case of a new (incompatible) major version to an existing version, a migration strategy has been developed
  • The model has at least version '1.0.0'

@bs-jokri bs-jokri requested a review from eriksven December 12, 2022 16:16
CONTRIBUTING.md Outdated Show resolved Hide resolved
@eriksven
Copy link
Contributor

eriksven commented Dec 13, 2022

@bs-jokri I pushed a commit fixing typos and changing the headline of the subsection to "License Header". What do you think?

@bs-jokri
Copy link
Contributor Author

@bs-jokri I pushed a commit fixing typos and changing the headline of the subsection to "License Header". What do you think?

LGTM I have found another issue as there was a incomplete sentence. @eriksven could you have another look and finish review and merge?

@eriksven eriksven requested review from eriksven and removed request for eriksven December 14, 2022 17:47
@eriksven
Copy link
Contributor

LGTM and thanks for finding the missing word.

@eriksven eriksven merged commit 6966c79 into eclipse-tractusx:main Dec 14, 2022
@eriksven eriksven deleted the add_description_of_license_header_to_contributing branch December 14, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants