Validation removed for Value field of specificAssetIds #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng shell descriptor
richaashara
changed the title
|
@richaashara I would mark this PR as invalid. We cannot remove the regex pattern as we need to follow the IDTA standards and need to keep the pattern defined by them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation removed for Value field of specificAssetIds while creating shell descriptor
Description
Few Special characters like + and = should be allowed if a business partner don't want to store the actual value in specific Ids and wants to store those specificAssetIds' values in encoded format then it should work.
This PR fixes the issue: #391
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: