Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Visibility of specificAssetId with wildcard and default closed #187

Conversation

tunacicek
Copy link
Contributor

@tunacicek tunacicek commented Aug 9, 2023

Description

Implement feature functionality:

  • SpecificAssetIds default closed: If no externalSubjectId is set, only the owner has access to this specificAssetId
  • make specificAssetId public with wildcardprefix: PUBLIC_READABLE: If externalsubjectId includes the prefix and allowedTypes matched, the specificAssetId is visible for everyone
  • If the consumer has only PUBLIC_READABLE specificAssetId -> Only read Access to the shell (only id and submodeldescriptors will be shown)
  • If the consumer is owner -> full access to the shell
  • If the consumer has no match to the specificAssetId (specificAssetIds=empty) -> The request shell will not return

Hint

This PR not includes the documenation. For the documentation, a separate PR will be created.

* SpecificAssetIds default closed: If no externalSubjectId is set, only the owner has access to this specificAssetId
* make specificAssetId public with wildcardprefix: PUBLIC_READABLE: If externalsubjectId includes the prefix, the specificAssetId is visible for everyone
@tunacicek tunacicek force-pushed the feature/implement-wildcard-default-closed branch from 907df22 to 2f11cd7 Compare August 22, 2023 12:18
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@agg3fe agg3fe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tunacicek tunacicek merged commit f97ee61 into eclipse-tractusx:main Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants