Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated issue templates #475

Conversation

kelaja
Copy link
Contributor

@kelaja kelaja commented Jan 17, 2024

Description

New Structure for Release Acceptance Criteria to make reviews more efficient.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs. -> Links to Catena-X Consortia Members still not fixed. Need to change asap!
  • Copyright and license header are present on all affected files

@kelaja kelaja requested a review from FaGru3n January 17, 2024 16:11
Copy link
Contributor

@FaGru3n FaGru3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some general information we aligend to remove CalVer form the templates and not linking Confluence again.

@@ -1,5 +1,5 @@
---
name: FOSS Release Compliance 23.12
name: FOSS Release Compliance 24.03
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kelaja

thanks for updating the Issue Templates, i think we should remove the CalVer from the issue templates

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @FaGru3n, yes this will be removed for 24.05. Release, we are currently in the process to define this general valid Templates for 24.05. For 24.03 we promised the FOSS-teams no additional process change, therefore please approve.

- Obtain approval from CX Gaia-X expert(s), prior to Gate review.
- Provide info as early as possible; expect optimization loops based on feedback
=> check [linked PDF](https://confluence.catena-x.net/download/attachments/90498572/SD_Data_for_Onboarding.pdf?version=1&modificationDate=1690457195303&api=v2) summary for requirements (Source only accessible for Catena-X Consortia members in current transition phase).

_Contact:_
- Release Mangement
- [Release Mangement](https://confluence.catena-x.net/x/DOZkBQ).
Copy link
Contributor

@FaGru3n FaGru3n Jan 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC we alligned to remove confluence links in Eclipse Tractus-X

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @FaGru3n, yes the "closed system"-links will be removed for 24.05. Release.

We are currently in the process to define general valid Templates for 24.05 together with the teams to work in future via TRGs.

For 24.03 we promised the FOSS-teams no additional process change, therefore please approve.

@SebastianBezold
Copy link
Contributor

I can only support @FaGru3n's comments here. Confluence links MUST go. Having anything that needs do be changed regularly like the release version also is something I would avoid.
This process will be the same for every release, so no need to mention a specific one

@FaGru3n
Copy link
Contributor

FaGru3n commented Jan 22, 2024

Hi @kelaja could we align on this that we all work together on this #479

I guess then we could all give our input to update the Issue templates?

For now i would close this pull-request, if your fine with it.

@kelaja
Copy link
Contributor Author

kelaja commented Jan 23, 2024

@FaGru3n wonderful its fine for me! Thanks a lot!

@kelaja kelaja closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants