Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dependecies update #366

Merged
merged 5 commits into from
Nov 16, 2023
Merged

chore: dependecies update #366

merged 5 commits into from
Nov 16, 2023

Conversation

tomaszbarwicki
Copy link
Contributor

DEPENDENCIES update + script to generate concatenated dependencies from release-automation and release-notifier.

Copy link
Contributor

@SebastianBezold SebastianBezold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

dash-input.sum Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be generated on the fly during the workflow run instead of adding it to the git history

@SebastianBezold
Copy link
Contributor

In a follow up step, we should document somewhere, that the DEPENDENCIES file does contain dependencies for both modules and link to your script for generating it, so no one get's confused about the small dependency list when generating "the old way"

@tomaszbarwicki
Copy link
Contributor Author

@SebastianBezold agreed, created a small issue for that to not forget #368

@tomaszbarwicki tomaszbarwicki merged commit 3e64991 into main Nov 16, 2023
4 checks passed
@tomaszbarwicki tomaszbarwicki deleted the chore/dependecies_update branch November 16, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants