Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updated trivy workflow #156

Merged
merged 1 commit into from
May 23, 2024

Conversation

adkumar1
Copy link
Contributor

  • As the trivy workflow is failing due to exit code 1
  • This is a problem in Trivy where even if you specifiy High and Critical, the workflow fails for medium vulnerability as well.

@adkumar1 adkumar1 requested a review from almadigabor May 22, 2024 10:24
Copy link
Contributor

@almadigabor almadigabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @RoKrish14, what do you think about this change? Did you find this problem as well before? I don't think letting trivy pass would without exit code 1 would be a good solution. Based on TRG8.04.

@RoKrish14
Copy link
Contributor

Hey @RoKrish14, what do you think about this change? Did you find this problem as well before? I don't think letting trivy pass would without exit code 1 would be a good solution. Based on TRG8.04.

Yes, you are right. I did not want to change anything in TRG in the middle of QG checks. However, this seems to be a problem coming from Trivy where the workflow fails even if there are "medium" vulnerabilities. I approved this request based on this scenario where all the High and Critical findings have been addressed.

I will make changes to the TRG related to Trivy after the release.
Would that be ok? or should I already do it now? (I would prefer to do it later)

@almadigabor almadigabor merged commit 114af9a into eclipse-tractusx:main May 23, 2024
6 checks passed
@almadigabor almadigabor deleted the fix-trivy branch May 23, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants