Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRG 1.02: Improve INSTALL.md #97

Closed
evegufy opened this issue Feb 21, 2024 · 0 comments · Fixed by #104
Closed

TRG 1.02: Improve INSTALL.md #97

evegufy opened this issue Feb 21, 2024 · 0 comments · Fixed by #104

Comments

@evegufy
Copy link
Contributor

evegufy commented Feb 21, 2024

Description

https://github.com/eclipse-tractusx/sd-factory/blob/v2.1.9/INSTALL.md

IMO there's quite a bit of confusing information in there, for instance:

  • 1.) Using helm commands: and 2.) Local installation: should maybe rather be called Installation from released chart and Installation from repository
  • with the command in 1.a your not adding helm repository in tractusx but you add the chart-repository from tractusx and to add that with the name sd-factory is quite misleading
  • 2.c and 2.d are contradictory
  • 2.e didn't try it myself but are you sure that that step even work as described

It's not a blocking issue for the QG check for 24.3 release but please make the change for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant