Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[e2e-testing/tutorial] improve helm-chart #91

Closed
3 tasks done
evegufy opened this issue Feb 15, 2024 · 0 comments · Fixed by #98
Closed
3 tasks done

[e2e-testing/tutorial] improve helm-chart #91

evegufy opened this issue Feb 15, 2024 · 0 comments · Fixed by #98
Labels
enhancement New feature or request

Comments

@evegufy
Copy link
Contributor

evegufy commented Feb 15, 2024 •
edited
Loading

Description

In order to support e2e-testing and tutorial / local setup, I suggest some improvements to the helm-chart.

Acceptance Criteria

  • provide image for arm64 cpu arch - in addition to amd64 (image doesn't work on newer Macs, this is relevant especially in the tutorial use case)
  • set default imagePullPolicy to IfNotPresent
  • make probes (readiness/liveness) configurable

Additional Information

evaluation done on v2.1.11

relates to eclipse-tractusx/sig-release#418

cc: @jzbmw
@evegufy evegufy added the enhancement New feature or request label Feb 15, 2024
@adkumar1 adkumar1 mentioned this issue Feb 22, 2024
Merged
evegufy pushed a commit that referenced this issue Feb 22, 2024
@adkumar1
fix: improve helm chart (#98)
b2e738e 
- Fixes #91 
- Helps in creating multi platform image
- Parameterising readiness & liveliness probe in the deployment
- Changing the ImagePullPolicy
@evegufy evegufy mentioned this issue Feb 26, 2024
Merged
@evegufy evegufy mentioned this issue Mar 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: improve helm chart catenax-ng/tx-sd-factory
1 participant
@evegufy