-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: ERP Adapter response interface #418
Feat: ERP Adapter response interface #418
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Mostly small things :) I created an issue for things we still should clarify and update afterwards
...ain/java/org/eclipse/tractusx/puris/backend/erp_adapter/controller/ErpAdapterController.java
Outdated
Show resolved
Hide resolved
...ain/java/org/eclipse/tractusx/puris/backend/erp_adapter/controller/ErpAdapterController.java
Outdated
Show resolved
Hide resolved
...ain/java/org/eclipse/tractusx/puris/backend/erp_adapter/controller/ErpAdapterController.java
Outdated
Show resolved
Hide resolved
...main/java/org/eclipse/tractusx/puris/backend/erp_adapter/domain/model/ErpAdapterRequest.java
Outdated
Show resolved
Hide resolved
...ain/java/org/eclipse/tractusx/puris/backend/erp_adapter/controller/ErpAdapterController.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/eclipse/tractusx/puris/backend/stock/logic/adapter/ItemStockSammMapper.java
Show resolved
Hide resolved
...ain/java/org/eclipse/tractusx/puris/backend/erp_adapter/controller/ErpAdapterController.java
Outdated
Show resolved
Hide resolved
...ain/java/org/eclipse/tractusx/puris/backend/erp_adapter/controller/ErpAdapterController.java
Outdated
Show resolved
Hide resolved
.../org/eclipse/tractusx/puris/backend/erpadapter/logic/service/ItemStockErpAdapterService.java
Dismissed
Show resolved
Hide resolved
.../org/eclipse/tractusx/puris/backend/erpadapter/logic/service/ItemStockErpAdapterService.java
Dismissed
Show resolved
Hide resolved
backend/src/main/java/org/eclipse/tractusx/puris/backend/common/util/VariablesService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fast implementation!
Description
Sample request body:
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: