Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/edc 0.7.0 infra #351

Merged
merged 21 commits into from
May 21, 2024
Merged

Chore/edc 0.7.0 infra #351

merged 21 commits into from
May 21, 2024

Conversation

tom-rm-meyer-ISST
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST commented Apr 29, 2024 •
edited
Loading

Description

  • switch edc charts to postgres version
  • version bump edc to tractus-x edc 0.7.0
  • add bdrs to infrastructure
  • add iam-mock for credential service and secure token service incl. did provisioning
  • make customer and supllier use one postgres for puris, edc, dtr (save resources)

contains temporary separate compose for edc

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 29, 2024
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KICS found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@mkanal mkanal mentioned this pull request Apr 30, 2024
Open
1 task
@tom-rm-meyer-ISST
Copy link
Contributor Author

tom-rm-meyer-ISST commented May 7, 2024 •
edited
Loading

Raised IP clearing for mock service:
[main] INFO A review is required for pypi/pypi/-/fastapi/0.109.0. approved 2024-05-09
[main] INFO A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14632 .
[main] INFO A review is required for pypi/pypi/-/uvloop/0.19.0. approved 2024-05-13
[main] INFO A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14633 .
[main] INFO A review is required for pypi/pypi/-/orjson/3.9.12. approved 2024-05-14
[main] INFO A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14634 .
[main] INFO A review is required for pypi/pypi/-/httptools/0.6.1. approved 2024-05-07
[main] INFO A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14635 .
[main] INFO A review is required for pypi/pypi/-/pycparser/2.22. approved 2024-05-07
[main] INFO A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14636 .
[main] INFO A review is required for pypi/pypi/-/dnspython/2.5.0. approved 2024-05-07
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14637 .
[main] INFO A review is required for pypi/pypi/-/ujson/5.9.0. approved 2024-05-14
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/14638 .

@tom-rm-meyer-ISST
Copy link
Contributor Author

tom-rm-meyer-ISST commented May 7, 2024 •
edited
Loading

Dependencies will be done later. This likely will be merged later. Will make the EDC changes independent of this branch and the EDC merge at the end.

Changes:

  • without whitespace (1712) (--stat -w main)
  • license headers (7 * 20 = 140)
  • Dependencies (40 + 36 requirements.txt =76)
  • docs (460)
  • duplicate docker compose to be deleted (docker-compose-edc) (139-20=119)
  • in total 1712 - 795 =917 (still excludes comments / documentation)

@tom-rm-meyer-ISST tom-rm-meyer-ISST requested a review from eschrewe May 7, 2024 14:04
@tom-rm-meyer-ISST tom-rm-meyer-ISST mentioned this pull request May 7, 2024
Merged
2 tasks
@tom-rm-meyer-ISST tom-rm-meyer-ISST marked this pull request as ready for review May 15, 2024 14:02
@tom-rm-meyer-ISST tom-rm-meyer-ISST requested review from mhellmeier and removed request for mhellmeier and eschrewe May 17, 2024 10:07
mhellmeier
mhellmeier approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@mhellmeier mhellmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. As described by @tom-rm-meyer-ISST, the LOC are under 1000 due to documentation and a new DEPENDENCIES file for the IAM mock.

@mhellmeier mhellmeier merged commit e1fb8e8 into eclipse-tractusx:main May 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhellmeier mhellmeier mhellmeier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tom-rm-meyer-ISST @mhellmeier