Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): added default password and replaced decoding in backend secrets #281

Merged

Conversation

tom-rm-meyer-ISST
Copy link
Contributor

Description

Helm upgrade test failed because of following things:

  • password has been empty but mustn't
  • decoding has been applied in secret instead of encoding

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

Copy link

gitguardian bot commented Feb 28, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

charts/puris/values.yaml Fixed Show fixed Hide fixed
Copy link
Contributor

@tomaszbarwicki tomaszbarwicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit 61d70d3 into eclipse-tractusx:main Feb 28, 2024
20 of 22 checks passed
@tom-rm-meyer-ISST tom-rm-meyer-ISST deleted the fix/helm-upgrade branch February 28, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants