-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add ItemStockSammMapperTest with fixes #144
Merged
mhellmeier
merged 8 commits into
eclipse-tractusx:main
from
FraunhoferISST:feat/itemStockSammMapperTest
Dec 21, 2023
Merged
Feat: add ItemStockSammMapperTest with fixes #144
mhellmeier
merged 8 commits into
eclipse-tractusx:main
from
FraunhoferISST:feat/itemStockSammMapperTest
Dec 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sting support - materialStock to ItemStockSamm - ItemStockSamm to ReportedProductItemStock
...ain/java/org/eclipse/tractusx/puris/backend/stock/logic/dto/itemstocksamm/ItemStockSamm.java
Dismissed
Show dismissed
Hide dismissed
...src/main/java/org/eclipse/tractusx/puris/backend/stock/logic/dto/itemstocksamm/Position.java
Dismissed
Show dismissed
Hide dismissed
tom-rm-meyer-ISST
requested review from
mhellmeier
and removed request for
mhellmeier
December 20, 2023 16:27
mhellmeier
requested changes
Dec 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The DEPENDENCIES_FRONTEND
doesn't seem to be up-to-date based on the pipeline.
Hi, I've triggered the job again. Seems like the dashtool was hanging. Everything is up to date. |
mhellmeier
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed during PR #108 and #109, for better understanding I created a test case for the mapper. We made adjustments on this branch.
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: