-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: added about license #115
Merged
tom-rm-meyer-ISST
merged 7 commits into
eclipse-tractusx:main
from
FraunhoferISST:feat/about-license
Dec 14, 2023
Merged
Feat: added about license #115
tom-rm-meyer-ISST
merged 7 commits into
eclipse-tractusx:main
from
FraunhoferISST:feat/about-license
Dec 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaMarzec
force-pushed
the
feat/about-license
branch
from
December 12, 2023 09:08
c53ead0
to
da041ab
Compare
tom-rm-meyer-ISST
requested changes
Dec 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great effort. Overall clean. Please incorporate comments.
- updating dependencies in frontend/DEPENDENCIES - removing Fraunhofer ISST from license header - outsourcing json information from AboutLicense.vue in aboutPage.json file - increased top-margin of 'About License' div while display height >= 665px Signed-off-by: Pascal Marzec <[email protected]>
tom-rm-meyer-ISST
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, smart solution using the json array!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new link called "About License" to the main navigation, which is structured according to TRG 7. 06.
Resolves #69
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: