Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: added about license #115

Merged

Conversation

PaMarzec
Copy link
Contributor

@PaMarzec PaMarzec commented Dec 8, 2023

Description

This PR adds a new link called "About License" to the main navigation, which is structured according to TRG 7. 06.

Resolves #69

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great effort. Overall clean. Please incorporate comments.

frontend/src/views/AboutLicense.vue Outdated Show resolved Hide resolved
frontend/src/views/AboutLicense.vue Outdated Show resolved Hide resolved
frontend/src/App.vue Outdated Show resolved Hide resolved
PaMarzec and others added 2 commits December 13, 2023 15:10
 - updating dependencies in frontend/DEPENDENCIES
 - removing Fraunhofer ISST from license header
 - outsourcing json information from AboutLicense.vue in aboutPage.json file
 - increased top-margin of 'About License' div while display height >= 665px

Signed-off-by: Pascal Marzec <[email protected]>
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, smart solution using the json array!

@tom-rm-meyer-ISST tom-rm-meyer-ISST changed the title Feat/about license Feat: added about license Dec 14, 2023
@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit 14e176b into eclipse-tractusx:main Dec 14, 2023
11 checks passed
@tom-rm-meyer-ISST tom-rm-meyer-ISST deleted the feat/about-license branch December 14, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Add View / Popup "About License" to Frontend.
2 participants