fix: validation check generates more verbose output

eclipse-tractusx · Dec 6, 2023 · 726d28f · 726d28f
1 parent d177469
commit 726d28f
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/...rc/main/java/org/eclipse/tractusx/puris/backend/stock/logic/service/ItemStockService.java b/...rc/main/java/org/eclipse/tractusx/puris/backend/stock/logic/service/ItemStockService.java
@@ -68,8 +68,8 @@ public List<ItemStock> findAll() {
 
     private boolean validate(ItemStock itemStock) {
         var key = itemStock.getKey();
+        Partner partner = key.getPartner();
         try {
-            Partner partner = key.getPartner();
             Objects.requireNonNull(partner, "Missing Partner");
             Objects.requireNonNull(key.getMaterial(), "Missing Material");
             Objects.requireNonNull(key.getDirection(), "Missing direction");
@@ -91,9 +91,10 @@ private boolean validate(ItemStock itemStock) {
                 .filter(address -> address.getBpna().equals(key.getLocationBpna())).findFirst().orElse(null);
             Objects.requireNonNull(stockBpna, "Unknown Bpna: " + key.getLocationBpna());
             var materialPartnerRelation = mprService.find(key.getMaterial(), partner);
-            Objects.requireNonNull(materialPartnerRelation, "Missing MaterialPartnerRelation");
+            Objects.requireNonNull(materialPartnerRelation, "Missing MaterialPartnerRelation between Partner " +
+                partner.getBpnl() + " and " + itemStock.getOwnMaterialNumber());
         } catch (Exception e) {
-            log.error("Validation failed: " + e.getMessage());
+            log.error("Validation failed: " + itemStock + "\n" + e.getMessage());
             return false;
         }
         return true;