Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: always set mvc routing basepath #182

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Feb 14, 2024

Description

Move the mvc routing base path configuration to a non if statement, that it's always set correctly.

Why

The sync in argo fails due to the missing configuration

Issue

Refs: 494

Checklist

  • I have performed a self-review of my changes
  • I have successfully tested my changes
  • I have added comments in the default values.yaml file with helm-docs syntax ('# -- ') if relevant for installation
  • I have commented my changes, particularly in hard-to-understand areas

@Phil91 Phil91 requested a review from evegufy February 14, 2024 07:10
charts/localdev/values.yaml Outdated Show resolved Hide resolved
@Phil91 Phil91 force-pushed the bugfix/mvc-routing branch from 0e24817 to 33729da Compare February 14, 2024 07:19
@Phil91 Phil91 requested a review from evegufy February 14, 2024 07:20
@Phil91 Phil91 merged commit a5a3d62 into release-candidate Feb 14, 2024
4 checks passed
@Phil91 Phil91 deleted the bugfix/mvc-routing branch February 14, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants