Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(new toggle switch): remove the on off text #330

Conversation

kunalgaurav-bmw
Copy link
Contributor

@kunalgaurav-bmw kunalgaurav-bmw commented Sep 25, 2024

Description

Removed the on off text from toggle switch

Why

On and Off text not required any more from demo feedback

Issue

#254

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally

@evegufy
Copy link
Contributor

evegufy commented Sep 25, 2024

Hi @kunalgaurav-bmw @oyo I looked into the failing dependencies check and it can be ignored in case of electron-to-chromium for now.
This IP Issue https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/16197 was opened by another Eclipse Project, for the dependency which was previously already considered approved by the Dash Tool and therefore is already integrated into our repo. What's strange is that the IP issue ran nonetheless into a manual review: I assume it's a false positive and will be approved in the next couple of days once somebody checks it out. So, let's monitor IP issue and see if we can update the DEPENDENCIES file in a couple of days.

@kunalgaurav-bmw kunalgaurav-bmw changed the title fix(new toggle switch): removed the on off text from toggle switch fix(new toggle switch): remove the on off text Sep 25, 2024
oyo
oyo previously approved these changes Oct 7, 2024
@evegufy
Copy link
Contributor

evegufy commented Oct 7, 2024

@kunalgaurav-bmw https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/16197 is approved, please update dependencies file

Copy link

sonarqubecloud bot commented Oct 7, 2024

@oyo oyo merged commit cb31a62 into eclipse-tractusx:main Oct 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

3 participants