You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced different kinds of identifiers for the company (e.g., Name, hostCompanyName, and customer) with LegalName and short LegalName.
Changelog entry
- **Updated Naming logic**
-Replaced companies name with legal identifiers [#1452](https://github.com/eclipse-tractusx/portal-frontend/issues/1452)
Why
Due to business requirements, the portal needs to display the short LegalName for businesses along with the LegalName. Some businesses might have longer names, so instead of the full name, we want to display the short LegalName.
@Usmanfee
Replacing attribute names of existing endpoints is not the way to go here. Old long name attribute should also stay as fallback to not disrupt anything. Looks like a huge amount of endpoint changes.
Please discuss in the issue with all relevant parties on how this should be implemented. This needs to go back to the drawing board imho. :(
Thanks @typecastcloud for the sneak peak.
I talked to @tfjanjua about it and listed all the api where the mentioned changed of FE expects new values and these value must be the part of response but you also make sense when it comes to fallback solution.
As for the relevant parties, most of the changes on the BE side will be made directly in the code rather than in any third-party service endpoint. I will check again by tomorrow!
CC @ybidois@dhiren-singh-007
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usmanfee
changed the title
Description
Replaced different kinds of identifiers for the company (e.g., Name, hostCompanyName, and customer) with LegalName and short LegalName.
Why
Due to business requirements, the portal needs to display the short LegalName for businesses along with the LegalName. Some businesses might have longer names, so instead of the full name, we want to display the short LegalName.
Issue
#1452
Dependency
BE needs to implement these respective changes on their side as well and then we will be able to test it.
related shared-component issue: eclipse-tractusx/portal-shared-components#422
shared-component PR: eclipse-tractusx/portal-shared-components#423
Checklist