feat(company data): extend legal entity pattern to support all language #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typecastcloud
force-pushed
the
feat/allow-all-language-characters
branch
from
979a2f8 to
940f5f6
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
|
Hi @typecastcloud, Change log entry is missing. |
typecastcloud
added a commit
to Cofinity-X/entry-portal-backend
that referenced
this pull request
Sep 19, 2024
The Company validation expression in the ValidationExpressions class has been updated to support a wider range of characters, including special characters and non-Latin alphabets. This change ensures that the validation accurately captures company names from different languages and regions. Fixes: eclipse-tractusx/portal#360 Refs: eclipse-tractusx/portal-frontend-registration#250
typecastcloud
force-pushed
the
feat/allow-all-language-characters
branch
from
940f5f6 to
f38d187
Compare
typecastcloud
added a commit
to Cofinity-X/entry-portal-backend
that referenced
this pull request
Sep 27, 2024
The Company validation expression in the ValidationExpressions class has been updated to support a wider range of characters, including special characters and non-Latin alphabets. This change ensures that the validation accurately captures company names from different languages and regions. Fixes: eclipse-tractusx/portal#360 Refs: eclipse-tractusx/portal-frontend-registration#250
6 tasks
Merged
5 tasks
|
@MaximilianHauer can you please prioritize this, please? This will make sure we don't run into errors when registering some of our existing customers during the Jupiter Go Live. |
|
fine for me @oyo's turn ;) |
typecastcloud
added a commit
to Cofinity-X/entry-portal-backend
that referenced
this pull request
Oct 11, 2024
The Company validation expression in the ValidationExpressions class has been updated to support a wider range of characters, including special characters and non-Latin alphabets. This change ensures that the validation accurately captures company names from different languages and regions. Fixes: eclipse-tractusx/portal#360 Refs: eclipse-tractusx/portal-frontend-registration#250
ntruchsess
pushed a commit
to eclipse-tractusx/portal-backend
that referenced
this pull request
Oct 14, 2024
The Company validation expression in the ValidationExpressions class has been updated to support a wider range of characters, including special characters and non-Latin alphabets. This change ensures that the validation accurately captures company names from different languages and regions. Fixes: eclipse-tractusx/portal#360 Refs: eclipse-tractusx/portal-frontend-registration#250 * Adjust changelog * Add remarks to Company regex * Update packages
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
oyo
requested changes
Oct 22, 2024
There was a problem hiding this comment.
@typecastcloud content approved but setting to request changes until merge conflicts resolved
The legal entity pattern now supports and uses letter and currency unicode categories. This required update of ecma script to version 6. Refs: eclipse-tractusx/portal#360
typecastcloud
force-pushed
the
feat/allow-all-language-characters
branch
from
842c0e4 to
21dc7ef
Compare
Hi @oyo, I rebased and updated dependencies. Thanks! |
|
oyo
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The legal entity pattern now supports and uses letter and currency unicode categories.
Why
International support requires a lot of different languages. Evaluating and reviewing REGEX by using ranges is very hard.
Issue
Refs: eclipse-tractusx/portal#360
Dep: eclipse-tractusx/portal-backend#1043
Checklist