Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added mandatory and filtered Active agreement status data #544

Merged
merged 2 commits into from
Mar 11, 2024
Merged

feat: added mandatory and filtered Active agreement status data #544

merged 2 commits into from
Mar 11, 2024

Conversation

VPrasannaK94
Copy link
Contributor

Description

added mandatory and filtered Active agreement status data

Why

added mandatory field and filtered Active agreement status data from app and service marketplace

Issue

N/A : CPLP-3651 , CPLP-3649

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@VPrasannaK94 VPrasannaK94 marked this pull request as ready for review March 1, 2024 07:37
@ntruchsess ntruchsess self-assigned this Mar 11, 2024
@ntruchsess ntruchsess force-pushed the feature/CPLP-3651/CPLP-3649-agreementStatus-mandatory branch 5 times, most recently from e6936eb to e2b5a44 Compare March 11, 2024 13:03
@ntruchsess ntruchsess force-pushed the feature/CPLP-3651/CPLP-3649-agreementStatus-mandatory branch from e2b5a44 to ad6ee9a Compare March 11, 2024 13:25
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

ntruchsess
ntruchsess approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@ntruchsess ntruchsess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did fix all findings

@ntruchsess ntruchsess merged commit e20f359 into eclipse-tractusx:dev Mar 11, 2024
8 checks passed
@ntruchsess ntruchsess deleted the feature/CPLP-3651/CPLP-3649-agreementStatus-mandatory branch March 11, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntruchsess ntruchsess ntruchsess approved these changes

@Phil91 Phil91 Awaiting requested review from Phil91

Assignees

@ntruchsess ntruchsess

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VPrasannaK94 @ntruchsess