Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(get): get company certificate types #490

Conversation

AnuragNagpure
Copy link
Contributor

Description

Static Data Endpoint to retrieve supported certificate types

Why

Suggested API Endpoint: GET /api/administration/staticdata/certificateTypes

Issue

#469

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@AnuragNagpure AnuragNagpure requested a review from Phil91 February 8, 2024 03:53
Copy link
Member

@Phil91 Phil91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a controller test as well

_dbContext.CompanyCertificateTypes.AsNoTracking()
.Select(certificate => new CompanyCertificateTypeData
(
certificate.Id.ToString(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CompanyCertificateId and Label are the same in this case, do we really need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jjeroch Do we need company_certificate_type.Id as only label is required to in frontend ?

cc @Phil91

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a talk with Julia and adjusted the endpoint accodingly. We only include the enum-value being automatically translated to the string (which is the same as the label in the database).

@Phil91
Copy link
Member

Phil91 commented Feb 8, 2024

One minor thing I recognised. Please always add @ntruchsess as a Reviewer as well

…m:catenax-ng/tx-portal-backend into feature/469-get-company-certificate-types
@AnuragNagpure
Copy link
Contributor Author

Please add a controller test as well

controller test added

@AnuragNagpure
Copy link
Contributor Author

One minor thing I recognised. Please always add @ntruchsess as a Reviewer as well

Noted

@Phil91
Copy link
Member

Phil91 commented Feb 8, 2024

I would wait for a response from Julia, but implementation wise the PR is ready to be approved and merged in my opinion

@Phil91 Phil91 changed the base branch from release/v1.8.0-RC5 to release/v1.8.0-RC6 February 8, 2024 13:24
@ntruchsess ntruchsess force-pushed the feature/469-get-company-certificate-types branch from 08ff419 to 06dffad Compare February 9, 2024 14:01
Copy link

sonarqubecloud bot commented Feb 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ntruchsess ntruchsess merged commit cd77d86 into eclipse-tractusx:release/v1.8.0-RC6 Feb 9, 2024
8 checks passed
@ntruchsess ntruchsess deleted the feature/469-get-company-certificate-types branch February 9, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants