-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(get): get company certificate types #490
feat(get): get company certificate types #490
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a controller test as well
src/administration/Administration.Service/Controllers/StaticDataController.cs
Outdated
Show resolved
Hide resolved
src/portalbackend/PortalBackend.DBAccess/Models/CompanyCertificateTypeData.cs
Outdated
Show resolved
Hide resolved
_dbContext.CompanyCertificateTypes.AsNoTracking() | ||
.Select(certificate => new CompanyCertificateTypeData | ||
( | ||
certificate.Id.ToString(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CompanyCertificateId and Label are the same in this case, do we really need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a talk with Julia and adjusted the endpoint accodingly. We only include the enum-value being automatically translated to the string (which is the same as the label in the database).
One minor thing I recognised. Please always add @ntruchsess as a Reviewer as well |
…m:catenax-ng/tx-portal-backend into feature/469-get-company-certificate-types
controller test added |
Noted |
I would wait for a response from Julia, but implementation wise the PR is ready to be approved and merged in my opinion |
src/portalbackend/PortalBackend.DBAccess/Repositories/StaticDataRepository.cs
Outdated
Show resolved
Hide resolved
src/portalbackend/PortalBackend.DBAccess/Repositories/StaticDataRepository.cs
Outdated
Show resolved
Hide resolved
src/portalbackend/PortalBackend.DBAccess/Repositories/StaticDataRepository.cs
Outdated
Show resolved
Hide resolved
src/portalbackend/PortalBackend.DBAccess/Models/CompanyCertificateTypeData.cs
Outdated
Show resolved
Hide resolved
08ff419
to
06dffad
Compare
Quality Gate passedIssues Measures |
cd77d86
into
eclipse-tractusx:release/v1.8.0-RC6
Description
Static Data Endpoint to retrieve supported certificate types
Why
Suggested API Endpoint: GET /api/administration/staticdata/certificateTypes
Issue
#469
Checklist
Please delete options that are not relevant.