-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(certificate): db enablement company certificates #475
feat(certificate): db enablement company certificates #475
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jjeroch the implementation in this PR adds a Id
field to the company_certificates
table. That differentiate to the description in the issue and I couldn't find a discussion in the issue nor Jira. Main reason for that is if we don't have the field a company could only have one entry linked to company_certificate_type. Example BMW
has an ISO 9001
certificate which is inactive, they could never create a new one, only way to have an ISO 9001
certificate is to update the inactive one, in my opinion we shouldn't do that, do you agree with that or should Anurag remove the Id field?
@AnuragNagpure one general thing I recognised, please use conventional commits not only for the PR title. Please use it for your commit messages as well
...ortalBackend.Migrations/Migrations/20240201084412_CPLP-3642-company-certificates.Designer.cs
Outdated
Show resolved
Hide resolved
src/portalbackend/PortalBackend.Migrations/Migrations/PortalDbContextModelSnapshot.cs
Outdated
Show resolved
Hide resolved
src/portalbackend/PortalBackend.Migrations/PortalBackend.Migrations.csproj
Outdated
Show resolved
Hide resolved
src/portalbackend/PortalBackend.Migrations/Seeder/BatchInsertSeeder.cs
Outdated
Show resolved
Hide resolved
...portalbackend/PortalBackend.Migrations/Seeder/Data/company_certificate_type_description.json
Outdated
Show resolved
Hide resolved
src/portalbackend/PortalBackend.PortalEntities/Entities/CompanyCertificate.cs
Outdated
Show resolved
Hide resolved
src/portalbackend/PortalBackend.PortalEntities/Entities/CompanyCertificateStatus.cs
Outdated
Show resolved
Hide resolved
src/portalbackend/PortalBackend.PortalEntities/Entities/CompanyCertificateType.cs
Outdated
Show resolved
Hide resolved
src/portalbackend/PortalBackend.PortalEntities/Entities/CompanyCertificateTypeDescription.cs
Outdated
Show resolved
Hide resolved
src/portalbackend/PortalBackend.PortalEntities/PortalDbContext.cs
Outdated
Show resolved
Hide resolved
Hi @Phil91 & @AnuragNagpure fully agree with your proposal. |
b25a7ad
to
9a0f301
Compare
9a0f301
to
584ed39
Compare
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
to end up with a single 1.8.0-rc5-migration the changes from #389 have been merged and the migration has been recreated. |
d608a73
into
eclipse-tractusx:release/v1.8.0-RC5
Description
Enable companies to fetch their company certificates with the respective document status.
Why
To ensure that the feature can get supported, first changes on db level are needed ++ seeding data adjustments. Tables added are mentioned below
CompanyCertificate
CompanyCertificateStatus
CompanyCertificateType
CompanyCertificateTypeDescription
Issue
#471
Checklist
Please delete options that are not relevant.