Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(conformity): enable conformity approval services #399

Conversation

AnuragNagpure
Copy link
Contributor

Description

db seeding data need to get enhanced.

Why

Adding required db seeding data for further enhancement in table portal.agreements

Issue

N/A Ref: CPLP-3580

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@AnuragNagpure AnuragNagpure changed the base branch from main to dev January 5, 2024 14:27
@Phil91
Copy link
Member

Phil91 commented Jan 7, 2024

@jjeroch is it correct that the new agreement isn't linked to a document and use case?

@jjeroch
Copy link
Contributor

jjeroch commented Jan 7, 2024

@jjeroch is it correct that the new agreement isn't linked to a document and use case?

@Phil91 thanks for sharing, we need to set the useCaseId, the rest is fine. Comment for Anurag added

@jjeroch jjeroch added the priority PR needs to prioritized at review label Jan 7, 2024
@AnuragNagpure AnuragNagpure force-pushed the feature/CPLP-3580-enable-conformity-Approval-Services branch from d45eeee to cc822d4 Compare January 8, 2024 05:30
Copy link

sonarqubecloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@AnuragNagpure AnuragNagpure requested a review from Phil91 January 8, 2024 05:37
@Phil91
Copy link
Member

Phil91 commented Jan 8, 2024

Corresponding CD-PR #139

@Phil91 Phil91 merged commit 7790690 into eclipse-tractusx:dev Jan 8, 2024
5 checks passed
@Phil91 Phil91 deleted the feature/CPLP-3580-enable-conformity-Approval-Services branch January 8, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority PR needs to prioritized at review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants