Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: upgrade to .net 9 #1161

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

build: upgrade to .net 9 #1161

wants to merge 2 commits into from

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Nov 19, 2024

Description

Upgrade .NET to v9

Why

To have the latest dotnet version in the projects

Issue

Refs: #1155

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Phil91 Phil91 requested review from evegufy and ntruchsess November 19, 2024 07:56
@Phil91 Phil91 added this to the Release 25.03 milestone Nov 19, 2024
@Phil91 Phil91 marked this pull request as draft November 19, 2024 08:25
@Phil91 Phil91 force-pushed the feature/1155-upgrade-net9 branch from 40a4056 to b67238e Compare November 19, 2024 12:35
@Phil91
Copy link
Member Author

Phil91 commented Nov 20, 2024

we need to wait for efcore/EFCore.NamingConventions#295 to be resolved

@Phil91 Phil91 force-pushed the feature/1155-upgrade-net9 branch from b67238e to d7a8a86 Compare December 3, 2024 11:51
@Phil91 Phil91 marked this pull request as ready for review December 3, 2024 11:51
@Phil91
Copy link
Member Author

Phil91 commented Dec 3, 2024

we need to wait for efcore/EFCore.NamingConventions#295 to be resolved

v9.0.0 was released to nuget

@Phil91
Copy link
Member Author

Phil91 commented Dec 3, 2024 •
edited
Loading

IP Issues were created

Npgsql/9.0.1
Mono.TextTemplating/3.0.0
Npgsql/9.0.0
Swashbuckle.AspNetCore.SwaggerGen/7.0.0
Swashbuckle.AspNetCore.Swagger/7.0.0
Laraue.EfCoreTriggers.Common/9.0.0
Swashbuckle.AspNetCore.SwaggerUI/7.0.0
Npgsql.EntityFrameworkCore.PostgreSQL/9.0.0
Laraue.EfCoreTriggers.PostgreSql/9.0.0
EFCore.NamingConventions/9.0.0
Swashbuckle.AspNetCore/7.0.0
Npgsql.EntityFrameworkCore.PostgreSQL/9.0.1
SwashBuckle.AspNetCore/7.0.0

@Phil91 Phil91 force-pushed the feature/1155-upgrade-net9 branch 6 times, most recently from c2d403b to b92bcc4 Compare December 10, 2024 08:34
@Phil91 Phil91 requested a review from typecastcloud December 12, 2024 09:16
@Phil91 Phil91 force-pushed the feature/1155-upgrade-net9 branch from b92bcc4 to c2b4551 Compare December 19, 2024 09:54
@Phil91 Phil91 force-pushed the feature/1155-upgrade-net9 branch from c2b4551 to 21fa59d Compare January 6, 2025 10:52
@ntruchsess ntruchsess self-assigned this Jan 23, 2025
@Phil91 Phil91 force-pushed the feature/1155-upgrade-net9 branch from 21fa59d to a45a54f Compare January 24, 2025 07:55
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Phil91
Copy link
Member Author

Phil91 commented Jan 24, 2025

IP Issues created for

nuget/nuget/-/xunit.runner.visualstudio/3.0.1
nuget/nuget/-/FluentAssertions/8.0.1

ntruchsess
ntruchsess requested changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@ntruchsess ntruchsess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides the failed dependency-check everything seems fine. I'll approve as soon the IP-issues are approved and the DEPENDENCIES file is updated accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntruchsess ntruchsess ntruchsess requested changes

@evegufy evegufy Awaiting requested review from evegufy

@typecastcloud typecastcloud Awaiting requested review from typecastcloud

Requested changes must be addressed to merge this pull request.

Assignees

@ntruchsess ntruchsess

Labels
None yet
Projects
Portal
Status: IN PROGRESS
Milestone
Release 25.03
Development

Successfully merging this pull request may close these issues.
2 participants
@Phil91 @ntruchsess