-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(technicalkey): unexpected response for post policy-content - Purpose #97
feat(technicalkey): unexpected response for post policy-content - Purpose #97
Conversation
src/database/PolicyHub.DbAccess/Repositories/PolicyRepository.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the current implementation only the left operand gets checked, the ticket mentions to check the value. at the moment there is no configuration for purposes to a given value set. I think we need to clarify with @jjeroch
21a4d95
to
517b82d
Compare
517b82d
to
2376e3e
Compare
Below changes are added as per description. PolicyAttributes remove - ID Trace 3.1 from policy_attributes map attribute_values: purpose.trace.v1.traceBattery to polcy_id = 01a0fba3-9b6e-435a-b045-e0e890c300c2 Policies remove the following policies including the linked data 01a0fba3-9b6e-435a-b045-e0e890c300b7 add a check to the post endpoint to validate the value of the request to be existing in the attributes_value table for the given policy /cc @jjeroch |
63ff8ce
to
4815d3f
Compare
Description
Error message with http status code 400 that value is not allowed. Only backend stored purposes are allowed; any other should run on an error
Why
The implementation should include the following requirements:
When the tester provides an input value that is not supported for the specified purposes, the endpoint should generate an error.
The error message displayed to the user should ideally include a comprehensive list of all allowed values for the input.
Please ensure that the implementation adheres to these guidelines.
Issue
#68
Checklist
Please delete options that are not relevant.