Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(actions): Separate actions file for add policy component #62

Merged
merged 4 commits into from
Feb 12, 2024

Conversation

ajithsimons
Copy link
Contributor

@ajithsimons ajithsimons commented Feb 7, 2024

Description

  • Separate actions file to optimise the add policy component

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@ajithsimons
Copy link
Contributor Author

Merge this after #61

Copy link
Contributor

@adityagajbhiye9 adityagajbhiye9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sachinargade123 sachinargade123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to update copyright 2024 for updated file.

@ajithsimons
Copy link
Contributor Author

@sachinargade123 fixed it.

Copy link
Contributor

@sachinargade123 sachinargade123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@almadigabor almadigabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust the license headers the same I mentioned here.

@ajithsimons
Copy link
Contributor Author

ajithsimons commented Feb 9, 2024

Please adjust the license headers the same I mentioned here.

@almadigabor Rebase was needed! Pls check it now!

@almadigabor almadigabor merged commit b6e5806 into eclipse-tractusx:main Feb 12, 2024
4 checks passed
@almadigabor almadigabor deleted the feature/policy_actions branch February 12, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants