Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(blank screen): lazy import pages reverted #54

Merged
merged 2 commits into from
Jan 4, 2024
Merged

fix(blank screen): lazy import pages reverted #54

merged 2 commits into from
Jan 4, 2024

Conversation

ajithsimons
Copy link
Contributor

@ajithsimons ajithsimons commented Dec 20, 2023 •
edited
Loading

Description

lazy import pages reverted to prevent blank screen issue

Pre-review checks

@ajithsimons
Copy link
Contributor Author

@sachinargade123 @adityagajbhiye Please review.

sachinargade123
sachinargade123 approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@sachinargade123 sachinargade123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adityagajbhiye9
Copy link
Contributor

Please merge this PR after PR #53

adityagajbhiye9
adityagajbhiye9 approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@adityagajbhiye9 adityagajbhiye9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adityagajbhiye9 adityagajbhiye9 mentioned this pull request Dec 21, 2023
Merged
2 tasks
@ajithsimons ajithsimons requested a review from FaGru3n December 27, 2023 18:23
@adityagajbhiye9 adityagajbhiye9 requested review from almadigabor and removed request for FaGru3n January 4, 2024 08:07
almadigabor
almadigabor approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@almadigabor almadigabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@almadigabor
Copy link
Contributor

Hey @adityagajbhiye9 @ajithsimons! There are merge conflicts, please resolve them.

almadigabor
almadigabor approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@almadigabor almadigabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@almadigabor almadigabor merged commit 2a02b9f into eclipse-tractusx:main Jan 4, 2024
4 checks passed
@almadigabor almadigabor deleted the bugfix/page-blank branch January 4, 2024 14:02
@ajithsimons ajithsimons self-assigned this Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityagajbhiye9 adityagajbhiye9 adityagajbhiye9 approved these changes

@sachinargade123 sachinargade123 sachinargade123 approved these changes

@almadigabor almadigabor almadigabor approved these changes

Assignees

@ajithsimons ajithsimons

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ajithsimons @adityagajbhiye9 @almadigabor @sachinargade123