Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node from 18.20.4-alpine3.20 to 22.7.0-alpine3.20 #178

Closed
wants to merge 1 commit into from
Closed

Bump node from 18.20.4-alpine3.20 to 22.7.0-alpine3.20 #178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@
# SPDX-License-Identifier: Apache-2.0
################################################################################
# => Build container
FROM node:18.20.4-alpine3.20 as builder
FROM node:22.7.0-alpine3.20 as builder

WORKDIR /app

RUN apk update && apk add --no-cache jq

Check warning on line 25 in Dockerfile

View workflow job for this annotation

GitHub Actions / Analyze

[MEDIUM] Unpinned Package Version in Apk Add 

Package version pinning reduces the range of versions that can be installed, reducing the chances of failure due to unanticipated changes

COPY ./package.json .

Expand All @@ -34,7 +34,7 @@

#### Stage 2: Serve the application from Nginx

FROM nginxinc/nginx-unprivileged:1.26.1-alpine3.19

Check warning on line 37 in Dockerfile

View workflow job for this annotation

GitHub Actions / Analyze

[LOW] Healthcheck Instruction Missing 

Ensure that HEALTHCHECK is being used. The HEALTHCHECK instruction tells Docker how to test a container to check that it is still working
# Nginx config
RUN rm -rf /etc/nginx/conf.d
USER root
Expand All @@ -42,9 +42,9 @@
# Static build
WORKDIR /usr/share/nginx/html
COPY LICENSE NOTICE.md DEPENDENCIES SECURITY.md ./
COPY --from=builder /app/build .

Check warning on line 45 in Dockerfile

View workflow job for this annotation

GitHub Actions / Analyze

[LOW] Multiple RUN, ADD, COPY, Instructions Listed 

Multiple commands (RUN, COPY, ADD) should be grouped in order to reduce the number of layers.
COPY ./env.sh .
RUN chown 101:101 /usr/share/nginx/html/

Check warning on line 47 in Dockerfile

View workflow job for this annotation

GitHub Actions / Analyze

[LOW] Multiple RUN, ADD, COPY, Instructions Listed 

Multiple commands (RUN, COPY, ADD) should be grouped in order to reduce the number of layers.
RUN chmod ug+rwx /usr/share/nginx/html/
EXPOSE 8080
USER 101
Expand Down
Loading