release1.2.8 #31
Merged
release1.2.8 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Veracode fixes
Veracode issue security web fix
Trivy fix and DEPENDENCIES file update
remove spring core 6.0.7 dependency version
Update pom.xml for veracode fix
sachinargade123
approved these changes
May 5, 2023
Merged
almadigabor
requested changes
May 9, 2023
INSTALL.md
Outdated
| @@ -8,7 +8,7 @@ How to install application using helm: <br /> | |||
| helm install ReleaseName ChartName | |||
|
|
|||
| a.) Add helm repository in tractusx: | |||
| helm repo add autosetup https://eclipse-tractusx.github.io/charts/dev | |||
| helm repo add autosetup https://eclipse-tractusx.github.io/charts/tractusx-dev | |||
There was a problem hiding this comment.
Suggested change
| helm repo add autosetup https://eclipse-tractusx.github.io/charts/tractusx-dev | |
| helm repo add tractusx-dev https://eclipse-tractusx.github.io/charts/tractusx-dev |
There was a problem hiding this comment.
Earlier we used few versions in middle for testing purpose so the plan was for 1.2.8, but i discussed with Sigi , he said we have to bump a version and should be in in sync with tractus-x repo versions. We should not put gap in between the versions.
Last version became 1.2.5, so we modified this as 1.2.6
almadigabor
requested changes
May 9, 2023
sachinargade123
approved these changes
May 12, 2023
|
@almadigabor: is there still any problem? Or why the code is still not committed? |
almadigabor
approved these changes
May 15, 2023
|
Can I merge this PR to main? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR #24 should be merged