Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/841 some cleanup first #860

Merged
merged 11 commits into from
Jul 31, 2024
Merged

Fix/841 some cleanup first #860

merged 11 commits into from
Jul 31, 2024

Conversation

dsmf
Copy link
Contributor

@dsmf dsmf commented Jul 30, 2024

Description

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

dsmf added 11 commits July 29, 2024 20:49
@dsmf
chore(impl): [eclipse-tractusx#841] add helper methods to ProcessingE…
8a17e05 
…rrorBuilder
@dsmf
chore(impl): [eclipse-tractusx#841] allow to continue builder using t…
c6e39e1 
…oBuilder = true
@dsmf
chore(quality): [eclipse-tractusx#841] reorder constants based on vis…
c57477c 
…ibility
@dsmf
chore(quality): [eclipse-tractusx#841] simplify
f0f30d0 
- inline method withProcessingError
- use the new helper methods from ProcessingErrorBuilder
@dsmf
chore(quality): [eclipse-tractusx#841] rename variable for better rea…
84aa7d9 
…dability
@dsmf
chore(quality): [#xxx] remove obsolete todo
1ea18d6
@dsmf
chore(quality): [eclipse-tractusx#841] simplify string construction
1e0cf3e
@dsmf
fix(exception-handling): [eclipse-tractusx#841] add bpn to timeout ex…
c047ffb 
…ception message
@dsmf
chore(quality): [eclipse-tractusx#841] extract code to method
ea86a63
@dsmf
chore(quality): [eclipse-tractusx#841] correct exception hierarchy of…
40f1f2a 
… UsagePolicy*Exception

Reason: These exceptions both have the same attributes. Making the PolicyException interface a base class and moving the attributes there simplifies exception handling allowing to deal with both exceptions in the same way without casting / type checking.
@dsmf
chore(quality): [eclipse-tractusx#841] missing import
aead813
@dsmf dsmf requested a review from ds-jhartmann July 30, 2024 11:15
@dsmf dsmf mentioned this pull request Jul 30, 2024
Closed
ds-jhartmann
ds-jhartmann approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@ds-jhartmann ds-jhartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ds-jhartmann ds-jhartmann merged commit 08811e3 into eclipse-tractusx:main Jul 31, 2024
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ds-jhartmann ds-jhartmann ds-jhartmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsmf @ds-jhartmann