Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/improve api comparison test #832

Merged
merged 5 commits into from
Jul 23, 2024
Merged

Chore/improve api comparison test #832

merged 5 commits into from
Jul 23, 2024

Conversation

dsmf
Copy link
Contributor

@dsmf dsmf commented Jul 19, 2024 •
edited by mkanal
Loading

Description

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

dsmf added 3 commits July 19, 2024 14:35
@dsmf
chore(test): [#xxx] Improve assertion message
055ee66
@dsmf
chore(test): [#xxx] Remove obsolete field ignores
41eb35a 
It seems that ignoring some fields is superfluous. It works without ignoring them currently. Therefore removed.
@dsmf
chore(test): [#xxx] update changelog
0ffda40
@dsmf dsmf requested a review from ds-jhartmann July 19, 2024 12:49
@dsmf dsmf mentioned this pull request Jul 19, 2024
Closed
9 tasks
ds-jhartmann
ds-jhartmann approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@ds-jhartmann ds-jhartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ds-jhartmann ds-jhartmann merged commit e2c1db4 into eclipse-tractusx:main Jul 23, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ds-jhartmann ds-jhartmann ds-jhartmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsmf @ds-jhartmann