Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/1190 delete catalog offers #812

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

ds-lcapellino
Copy link
Contributor

Description

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

Copy link

CHANGELOG file was not updated! Make sure to include important changes.

@ds-lcapellino ds-lcapellino force-pushed the feature/1190-delete-catalog-offers branch from 14eea6b to 5d04772 Compare July 16, 2024 13:53
…ition and deleteContractDefinition functionality
@ds-lcapellino ds-lcapellino force-pushed the feature/1190-delete-catalog-offers branch from 5d04772 to 79bdd32 Compare July 16, 2024 13:59
Copy link

@Setter
@AllArgsConstructor
@NoArgsConstructor
@Builder

Check notice

Code scanning / CodeQL

Use of default toString() Note

Default toString(): EdcContext inherits toString() from Object, and so is not suitable for printing.
Copy link
Contributor

@ds-jhartmann ds-jhartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ds-jhartmann ds-jhartmann merged commit e6a2a2b into main Jul 16, 2024
17 checks passed
@ds-jhartmann ds-jhartmann deleted the feature/1190-delete-catalog-offers branch July 16, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants