Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(policy-store): [#trace-foss-970] return rightOperand without odrl… #725

Conversation

dsmf
Copy link
Contributor

@dsmf dsmf commented Jun 21, 2024

Description

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

dsmf added 3 commits June 21, 2024 16:45
- JsonProperty is not needed at all (removed for consistency with the other attributes)
- removed superfluous brackets in annotation with only value

(works implicitly as with the other attributes)
@dsmf dsmf marked this pull request as ready for review June 21, 2024 16:07
@dsmf dsmf requested review from ds-jhartmann and mkanal June 21, 2024 16:10
Copy link
Contributor

@ds-jhartmann ds-jhartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ds-jhartmann ds-jhartmann dismissed mkanal’s stale review June 24, 2024 07:11

comments are addressed

@ds-jhartmann ds-jhartmann merged commit 8398347 into eclipse-tractusx:main Jun 24, 2024
15 of 16 checks passed
@dsmf dsmf deleted the fix/trace-foss-970-return-rightOperand-without-prefix branch July 15, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants